Redis do not delete the expired keys

Bug #1417464 reported by zhangjialong
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Undecided
zhangjialong
oslo.messaging (Ubuntu)
Fix Released
High
Unassigned
Vivid
Fix Released
High
Unassigned

Bug Description

When using redis as zmq backend,the keys in redis maybe like follows:

 "service"
 "service.host1"
 "service.host1.host1"
 "service.host2"
 "service.host2.host2"
 "service.host3"
 "service.host3.host3"

If we stopped the service on host1, the key named
service.host1 and service.host1.host1 shoule be delete.
As the result, the topicexchange message would not sent to host1.
But the fact is service.host1 still exsit, and topicexchange message may still sent to host1.

zhangjialong (zhangjl)
Changed in oslo.messaging:
assignee: nobody → zhangjialong (zhangjl)
zhangjialong (zhangjl)
tags: added: redis
zhangjialong (zhangjl)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/152471

Changed in oslo.messaging:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/152471
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=1958f6e549d3769202960f5af93982afea74cd80
Submitter: Jenkins
Branch: master

commit 1958f6e549d3769202960f5af93982afea74cd80
Author: zhangjl <email address hidden>
Date: Tue Feb 3 18:56:47 2015 +0800

    Fix the bug redis do not delete the expired keys

    When using redis as zmq backend,
    the keys in redis maybe like follows:

     "service"
     "service.host1"
     "service.host1.host1"
     "service.host2"
     "service.host2.host2"
     "service.host3"
     "service.host3.host3"

    If we stopped the service on host1, the key named
    service.host1 and service.host1.host1 shoule be
    delete. As the result, the topicexchange message
    would not sent to host1. But the fact is
    service.host1 still exsit, and topicexchange
    message may still sent to host1.

    To resolve this problem , change the comparison of
    ttl function from -1 to -2 according to
    http://redis.io/commands/ttl

    Change-Id: I5c0af97019fffed6e949eb58d7d60c85f5b08ea1
    Closes-Bug:#1417464

Changed in oslo.messaging:
status: In Progress → Fix Committed
Changed in oslo.messaging:
milestone: none → 1.8.1
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
milestone: 1.8.1 → next-liberty
Changed in oslo.messaging:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/172038

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (stable/kilo)

Reviewed: https://review.openstack.org/172038
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=671c60d3a5c21169978805ca4ed616941a3aeabf
Submitter: Jenkins
Branch: stable/kilo

commit 671c60d3a5c21169978805ca4ed616941a3aeabf
Author: zhangjl <email address hidden>
Date: Tue Feb 3 18:56:47 2015 +0800

    Fix the bug redis do not delete the expired keys

    When using redis as zmq backend,
    the keys in redis maybe like follows:

     "service"
     "service.host1"
     "service.host1.host1"
     "service.host2"
     "service.host2.host2"
     "service.host3"
     "service.host3.host3"

    If we stopped the service on host1, the key named
    service.host1 and service.host1.host1 shoule be
    delete. As the result, the topicexchange message
    would not sent to host1. But the fact is
    service.host1 still exsit, and topicexchange
    message may still sent to host1.

    To resolve this problem , change the comparison of
    ttl function from -1 to -2 according to
    http://redis.io/commands/ttl

    Change-Id: I5c0af97019fffed6e949eb58d7d60c85f5b08ea1
    Closes-Bug:#1417464
    (cherry picked from commit 1958f6e549d3769202960f5af93982afea74cd80)

tags: added: in-stable-kilo
James Page (james-page)
Changed in oslo.messaging (Ubuntu Wily):
status: New → Fix Released
Changed in oslo.messaging (Ubuntu Vivid):
status: New → Triaged
importance: Undecided → High
Changed in oslo.messaging (Ubuntu Wily):
importance: Undecided → High
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello zhangjialong, or anyone else affected,

Accepted oslo.messaging into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/oslo.messaging/1.8.3-0ubuntu0.15.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in oslo.messaging (Ubuntu Vivid):
status: Triaged → Fix Committed
tags: added: verification-needed
James Page (james-page)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package oslo.messaging - 1.8.3-0ubuntu0.15.04.1

---------------
oslo.messaging (1.8.3-0ubuntu0.15.04.1) vivid; urgency=medium

  * New upstream point release (LP: #1467959):
    - RabbitMQ driver:
      + Adding publisher acknowledgements/confirms for better handling
        of messages during broker shutdown/network failure.
      + Ensure consumer connections closed properly (LP: #1458917).
      + Set timeout on the underlying socket (LP: #1436788).
      + Disable and mark heartbeat as experimental (LP: #1436769).
      + Fix ipv6 support.
    - ZeroMQ driver:
      + Don't raise Timeout on no-matchmaker results (LP: #1186310).
      + Fix issue with Redis not deleting expired keys (LP: #1417464).
      + d/p/Fix-changing-keys-during-iteration-in-matchmaker-hea.patch,
        d/p/Add-pluggability-for-matchmakers.patch: Dropped, included
        upstream.

 -- James Page <email address hidden> Tue, 23 Jun 2015 15:28:01 +0100

Changed in oslo.messaging (Ubuntu Vivid):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for oslo.messaging has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello zhangjialong, or anyone else affected,

Accepted oslo.messaging into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/oslo.messaging/1.8.3-0ubuntu0.15.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-done
tags: added: verification-needed
James Page (james-page)
tags: added: verification-done
removed: verification-needed
Mathew Hodson (mhodson)
no longer affects: oslo.messaging (Ubuntu Wily)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.