Merge lp:~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness into lp:ocb-addons
Proposed by
Paul Catinean
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Holger Brunn (Therp) | ||||
Proposed branch: | lp:~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness | ||||
Merge into: | lp:ocb-addons | ||||
Diff against target: |
52 lines (+15/-0) 4 files modified
delivery/__openerp__.py (+1/-0) delivery/delivery.py (+1/-0) delivery/delivery_view.xml (+1/-0) delivery/security/delivery_security.xml (+12/-0) |
||||
To merge this branch: | bzr merge lp:~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Holger Brunn (Therp) | Disapprove | ||
Guewen Baconnier @ Camptocamp | Approve | ||
Stefan Rijnhart (Opener) | Approve | ||
Review via email: mp+214176@code.launchpad.net |
Description of the change
[FIX] Added multi-company awareness to delivery module
To post a comment you must log in.
Unmerged revisions
- 10075. By Paul Catinean
-
[FIX] Fixed view to match standard conventions
- 10074. By Paul Catinean
-
[FIX] Removed default value for company_id, cleaned up syntax
- 10073. By Paul Catinean
-
[FIX] Added multi-company awareness to delivery module
This could seriously mess up existing installations. I'm not against the new field, but having the default function in OCB means that when this field is added, all carriers get the company of the admin user, making all carriers unavailable instantly when working on other companies before reconfiguration. Even having it in the official distribution is debatable IMHO, sharing carriers seems like a sane default to me. Would you consider removing the default?
Syntactically, your spacing seems off in both python and xml files. Do you mix tabs and spaces?
l.20: required=False is void as this is the default.