Code review comment for lp:~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness

Revision history for this message
Paul Catinean (wiz-keed) wrote :

I did do it on purpose taking into example indeed the product/pricelist/shop model.The only logic used in here is that if the company is a child of the one set it should inherit it's delivery methods.

I though it would be confusing for someone that made the parent-child structure why it should not appear in a child if the delivery is set on the parent company and if he would want it visible on all he should remove company all together.

Furthermore I think it allows more granular filtration (for example two parent companies and with 2 children each).One could set delivery methods on the two parent companies to make available for all children and company-specific as well

IMO it has no drawbacks and gives only more flexibility, It's up to you on this one though, I have just started working with multi-company 1 week ago and lack experience on this subject

Let me know what I should do

« Back to merge proposal