Code review comment for lp:~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness
Revision history for this message
| Stefan Rijnhart (Opener) (stefan-opener) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
This could seriously mess up existing installations. I'm not against the new field, but having the default function in OCB means that when this field is added, all carriers get the company of the admin user, making all carriers unavailable instantly when working on other companies before reconfiguration. Even having it in the official distribution is debatable IMHO, sharing carriers seems like a sane default to me. Would you consider removing the default?
Syntactically, your spacing seems off in both python and xml files. Do you mix tabs and spaces?
l.20: required=False is void as this is the default.