Merge lp:~vanvugt/compiz/fix-1097657 into lp:compiz/0.9.9

[Daniel van Vugt]

Avoid leaking PrivateGLScreen::projection (LP: #1097657)

[Sam Spilsbury (smspillaz)]

See previous statement on the usage of auto_ptr.

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3550
http://jenkins.qa.ubuntu.com/job/compiz-ci/355/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/355/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-ci/355//rebuild/?

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3550
http://jenkins.qa.ubuntu.com/job/compiz-gles-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-gles-ci/./build=pbuilder,distribution=quantal,flavor=amd64/6/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-gles-ci/6//rebuild/?

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3550
http://jenkins.qa.ubuntu.com/job/compiz-clang-ci/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-clang-ci/./build=pbuilder,distribution=quantal,flavor=amd64/7/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-clang-ci/7//rebuild/?

review: Approve (continuous-integration)

[Daniel van Vugt (vanvugt)]

Remembering to use "auto_ptr" probably requires just as much brainpower, if not more, as remembering a delete in your destructor. :(

[Sam Spilsbury (smspillaz)]

It becomes automatic after a while :)

On Thu, Jan 10, 2013 at 11:37 AM, Daniel van Vugt
<email address hidden> wrote:
> Remembering to use "auto_ptr" probably requires just as much brainpower, if not more, as remembering a delete in your destructor. :(
> --
> https://code.launchpad.net/~vanvugt/compiz/fix-1097657/+merge/142473
> You are reviewing the proposed merge of lp:~vanvugt/compiz/fix-1097657 into lp:compiz.

--
Sam Spilsbury

=== modified file 'plugins/opengl/src/screen.cpp'
--- plugins/opengl/src/screen.cpp	2013-01-04 07:36:56 +0000
+++ plugins/opengl/src/screen.cpp	2013-01-09 10:59:23 +0000
@@ -1257,6 +1257,7 @@
 
 PrivateGLScreen::~PrivateGLScreen ()
 {
+    delete projection;
     delete programCache;
     delete autoProgram;
     if (rootPixmapCopy)