Merge lp:~vanvugt/compiz/fix-1097657 into lp:compiz/0.9.9

Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3550
Merged at revision: 3551
Proposed branch: lp:~vanvugt/compiz/fix-1097657
Merge into: lp:compiz/0.9.9
Diff against target: 11 lines (+1/-0)
1 file modified
plugins/opengl/src/screen.cpp (+1/-0)
To merge this branch: bzr merge lp:~vanvugt/compiz/fix-1097657
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sam Spilsbury Approve
Review via email: mp+142473@code.launchpad.net

Commit message

Avoid leaking PrivateGLScreen::projection (LP: #1097657)

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

See previous statement on the usage of auto_ptr.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Remembering to use "auto_ptr" probably requires just as much brainpower, if not more, as remembering a delete in your destructor. :(

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

It becomes automatic after a while :)

On Thu, Jan 10, 2013 at 11:37 AM, Daniel van Vugt
<email address hidden> wrote:
> Remembering to use "auto_ptr" probably requires just as much brainpower, if not more, as remembering a delete in your destructor. :(
> --
> https://code.launchpad.net/~vanvugt/compiz/fix-1097657/+merge/142473
> You are reviewing the proposed merge of lp:~vanvugt/compiz/fix-1097657 into lp:compiz.

--
Sam Spilsbury

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/opengl/src/screen.cpp'
2--- plugins/opengl/src/screen.cpp 2013-01-04 07:36:56 +0000
3+++ plugins/opengl/src/screen.cpp 2013-01-09 10:59:23 +0000
4@@ -1257,6 +1257,7 @@
5
6 PrivateGLScreen::~PrivateGLScreen ()
7 {
8+ delete projection;
9 delete programCache;
10 delete autoProgram;
11 if (rootPixmapCopy)

Subscribers

People subscribed via source and target branches