Merge ~toabctl/jenkins-launchpad-plugin:master-fix-tests into jenkins-launchpad-plugin:master

Proposed by Thomas Bechtold
Status: Merged
Merged at revision: 7dfde3e0f00e22c8337dcfef8878b534da16c187
Proposed branch: ~toabctl/jenkins-launchpad-plugin:master-fix-tests
Merge into: jenkins-launchpad-plugin:master
Diff against target: 34 lines (+3/-2)
2 files modified
jlp/commands/launchpadTrigger.py (+1/-0)
tests/test_launchpadTrigger.py (+2/-2)
Reviewer Review Type Date Requested Status
Paride Legovini Approve
Review via email: mp+430316@code.launchpad.net

Commit message

Fix tests

To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

I can confirm the tests pass now. Thanks!

review: Approve
Revision history for this message
Paride Legovini (paride) wrote :

I can confirm the tests pass now. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/jlp/commands/launchpadTrigger.py b/jlp/commands/launchpadTrigger.py
index 0d4649b..0bc4dd3 100644
--- a/jlp/commands/launchpadTrigger.py
+++ b/jlp/commands/launchpadTrigger.py
@@ -33,6 +33,7 @@ def trigger_jenkins(branch,
33 jenkins_url=None,33 jenkins_url=None,
34 fasttrack_merge=False,34 fasttrack_merge=False,
35 lock_name='',35 lock_name='',
36 lock_timeout=None,
36 repo_type='auto'):37 repo_type='auto'):
37 """Trigger a Jenkins build."""38 """Trigger a Jenkins build."""
3839
diff --git a/tests/test_launchpadTrigger.py b/tests/test_launchpadTrigger.py
index 78075e1..5060724 100644
--- a/tests/test_launchpadTrigger.py
+++ b/tests/test_launchpadTrigger.py
@@ -189,7 +189,7 @@ class TestLockNames(PatchedLaunchpadTriggerTest):
189 as socketLock:189 as socketLock:
190 launchpadTrigger()190 launchpadTrigger()
191 socketLock.assert_called_with(191 socketLock.assert_called_with(
192 get_config_option('lock_name') + '-launchpadTrigger')192 get_config_option('lock_name') + '-launchpadTrigger', None)
193193
194 def test_trigger_with_lock_name(self):194 def test_trigger_with_lock_name(self):
195 """Trigger autolanding with a custom launchpadlib lockname."""195 """Trigger autolanding with a custom launchpadlib lockname."""
@@ -200,7 +200,7 @@ class TestLockNames(PatchedLaunchpadTriggerTest):
200 as socketLock:200 as socketLock:
201 launchpadTrigger()201 launchpadTrigger()
202 socketLock.assert_called_with(202 socketLock.assert_called_with(
203 get_config_option('lock_name') + '-' + lock_name)203 get_config_option('lock_name') + '-' + lock_name, None)
204204
205205
206class TestTriggerJenkins(unittest.TestCase):206class TestTriggerJenkins(unittest.TestCase):

Subscribers

People subscribed via source and target branches