View Bazaar branches
Get this repository:
git clone https://git.launchpad.net/jenkins-launchpad-plugin
Members of Jenkaas Hackers can upload to this repository. Log in for directions.

jenkins-launchpad-plugin has 6 active reviews. See all merge proposals.

Branches

Name Last Modified Last Commit
master 2023-06-08 16:14:21 UTC
fix(launchpadTrigger): lock-timeout type error

Author: Stefan Hammer
Author Date: 2023-06-08 16:08:27 UTC

fix(launchpadTrigger): lock-timeout type error

Default argparse argument (lock-timeout) gets stored as a string, which
is not compatible with SocketLock needing timeout to be an int. This
lead to the following type of error:

```
launchpadTrigger --lock-name=maint-ci-cloudware-image_naming-trigger
    --job=maint-ci-cloudware-image_naming-test
    '--branch=lp:~cloudware/cloudware/+git/image_naming' --trigger-ci
    --repo_type=git --lock-timeout=60
DEBUG: Going to acquire launchpad lock
"launchpad-trigger-lock-maint-ci-cloudware-image_naming-trigger" for
    launchpadTrigger
Traceback (most recent call last):
    File "/usr/bin/launchpadTrigger", line 11, in <module>
        load_entry_point('jenkins-launchpad-plugin==19.1',
                'console_scripts', 'launchpadTrigger')()
    File
    "/usr/lib/python3/dist-packages/jlp/commands/launchpadTrigger.py",
    line 100, in launchpadTrigger
        with SocketLock(trigger_lock_name, args['lock_timeout']):
    File "/usr/lib/python3/dist-packages/jlp/socketlock.py",
    line 64, in __enter__
        self.acquire()
    File "/usr/lib/python3/dist-packages/jlp/socketlock.py", line
    39, in acquire
        if timeout is not None and timeout > 0:
TypeError: '>' not supported between instances of 'str'
and 'int'
```

Fix is to cast it to int if a str is passed into SocketLock.acquire().

py2 2021-03-02 13:48:27 UTC
Add a comment as a fallback if nominateReviewer fails in start_jenkins_job

Author: Tom Haddon
Author Date: 2021-03-02 13:48:27 UTC

Add a comment as a fallback if nominateReviewer fails in start_jenkins_job

12 of 2 results

Other repositories

You can't create new repositories for jenkins-launchpad-plugin.