jenkins-launchpad-plugin:master

Last commit made on 2023-06-08
Get this branch:
git clone -b master https://git.launchpad.net/jenkins-launchpad-plugin
Members of Jenkaas Hackers can upload to this branch. Log in for directions.

Branch merges

Branch information

Name:
master
Repository:
lp:jenkins-launchpad-plugin

Recent commits

3f0f646... by Stefan Hammer

fix(launchpadTrigger): lock-timeout type error

Default argparse argument (lock-timeout) gets stored as a string, which
is not compatible with SocketLock needing timeout to be an int. This
lead to the following type of error:

```
launchpadTrigger --lock-name=maint-ci-cloudware-image_naming-trigger
    --job=maint-ci-cloudware-image_naming-test
    '--branch=lp:~cloudware/cloudware/+git/image_naming' --trigger-ci
    --repo_type=git --lock-timeout=60
DEBUG: Going to acquire launchpad lock
"launchpad-trigger-lock-maint-ci-cloudware-image_naming-trigger" for
    launchpadTrigger
Traceback (most recent call last):
    File "/usr/bin/launchpadTrigger", line 11, in <module>
        load_entry_point('jenkins-launchpad-plugin==19.1',
                'console_scripts', 'launchpadTrigger')()
    File
    "/usr/lib/python3/dist-packages/jlp/commands/launchpadTrigger.py",
    line 100, in launchpadTrigger
        with SocketLock(trigger_lock_name, args['lock_timeout']):
    File "/usr/lib/python3/dist-packages/jlp/socketlock.py",
    line 64, in __enter__
        self.acquire()
    File "/usr/lib/python3/dist-packages/jlp/socketlock.py", line
    39, in acquire
        if timeout is not None and timeout > 0:
TypeError: '>' not supported between instances of 'str'
and 'int'
```

Fix is to cast it to int if a str is passed into SocketLock.acquire().

7dfde3e... by Thomas Bechtold

Fix tests

Commit 639e035d455c did change launchpadTrigger.py without adjusting
the tests. This is now fixed.

f127a70... by Thomas Bechtold

Log exception when socket.error occurs

When an Exception got raised during acquiring a SocketLock, do log
that exception so it's easier to understand the underlying problem.

639e035... by Thomas Bechtold

add --lock-timeout parameter to launchpadTrigger command

Currently there is no timeout so if something goes wrong with trying
to acquire a SocketLock, launchpadTrigger hands in an endless loop.
Having an option to provide a timeout can solve this.

16d08ec... by Tom Haddon

Add a log message explaining why we're adding a comment rather than nominating a review

1355e10... by Tom Haddon

Add a comment as a fallback if nominateReviewer fails in start_jenkins_job

016162f... by Paride Legovini

d/changelog: rephrase (cosmetic)

Gbp-Dch: ignore

f0efc20... by Paride Legovini

d/control: downgrade to debhelper-compat 12 to build on Focal

3f63202... by Paride Legovini

voteOnMergeProposal: really fail CI if no commit message is present

6a83b4f... by Paride Legovini

d/control: bump dh compat level to 13