Merge ~gunnarhj/chromium-browser/+git/snap-from-source:flash-fix into ~chromium-team/chromium-browser/+git/snap-from-source:stable
Proposed by
Gunnar Hjalmarsson
Status: | Merged |
---|---|
Merged at revision: | 65f47e45168be9455ca02c38a3312ae460e7b3f9 |
Proposed branch: | ~gunnarhj/chromium-browser/+git/snap-from-source:flash-fix |
Merge into: | ~chromium-team/chromium-browser/+git/snap-from-source:stable |
Diff against target: |
20 lines (+4/-3) 1 file modified
launcher/chromium.launcher (+4/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Tilloy | Needs Fixing | ||
Review via email: mp+368847@code.launchpad.net |
Description of the change
This change is desired irrespective of what happens with my confinement idea. Without it Chromium unnecessarily complains about the plugin being too old.
To post a comment you must log in.
Good catch Gunnar, thanks!
This looks mostly fine to me, but in practice it doesn't work because: "strings: command not found" inside confinement. We would need to add binutils-$ARCH and libbinutils to the stage packages (and we would probably want to keep only the strings binary, filtering out all the other utilities).
Also you will need to remove the double quotes around $FLASH_OPTIONS in the exec line, otherwise chromium will interpret the contents of the variable as one single parameter, and will fail to load the shared library.