Code review comment for ~gunnarhj/chromium-browser/+git/snap-from-source:flash-fix

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Thanks for looking! Didn't realize that also strings() requires a confinement adjustment. (Why is the confinement sooo restrictive?)

If you talk to someone about modifying the confinement, please take the opportunity to ask them to fix it for adobe-flashplugin and pepperflashplugin-nonfree too. :)

As regards the quotes, are you sure? The "$@" is quoted, and it seems to allow for multiple options to be passed manually. But to be honest I was in doubt; submitted a commit which removes them.

« Back to merge proposal