Merge lp:~dukrat/mailman/star_accept_these_nonmembers_override into lp:mailman/2.1

[Robert Arlt Jr.]

Adds options to have the *_these_nonmembers override the posting rights of members included in *_these_nonmembers on a per list per *_these_nonmembers basis.

[Mark Sapiro (msapiro)]

I don't recall if I saw this proposal when it was first submitted. If I did, I apologize for not responding.

In any case, I'm not going to accept it because I really don't see the need for it. If you want *_these_nonmembers to apply to an address which is a member, just delete the member. Granted, there are corner cases, e.g. if Reply-To: is a member but From: isn't, where this might produce a different result, I still don't see it as a useful feature.

review: Disapprove (design)

[Mark Sapiro (msapiro)]

OK. thinking a bit further, I suppose you may not want to remove the member because you want her to still receive list mail.

You could still accomplish the same thing as a hold/reject/discard these_nonmembers override would by using header_filter_rules, and for accept_these_nonmembers overriding member_moderation_action, just unmoderate the member.

It there's something I'm missing here, please explain your use cases in more detail so I can understand the need.

[Robert Arlt Jr. (dukrat)]

It has been some years and I'm not actively using this so I could have some misconceptions at this point, but I do not believe the header_filter_rules will leverage the @list notation that the _these_nonmembers does.

The use case being the administrator of list x needs everyone on list y to be able to send to list x unmoderated. However, they do not moderate list y and do not have knowledge of who is on list y. Therefore they cannot know if any of list x members should be unmoderated nor would they know who the put in the header_filter_rules.

[Mark Sapiro (msapiro)]

I think I understand your use case, and I think you are correct that in this case, there is no way to accomplish the desired result with existing settings. I.e., if there is a member of list x who also happens to be a moderated member of list y, and that member should be allowed to post unmoderated to list y by virtue of being a member of list x, the admin of list y who is unaware of the membership of list x will not know to unmoderate the member on list y.

I note that you are at MIT, and I suspect that this could actually be a real case in a university environment. I.e. I run the radio club's list and the dean's 'special privileged people' should be able to post to my list unmoderated even though one of them is a moderated member of my list and I'm unaware that this is one of the dean's 'special privileged people'.

However, I see the need for this being so rare in practice that, university politics notwithstanding, it isn't worth the additional complexity and potential confusion that these extra settings would produce. Further, I see issues if both @deans_friends and <email address hidden> are in my list's accept_these_nonmembers with accept_these_nonmembers_override = Yes and at some later time <email address hidden> joins my list and then I want to moderate her for some reason and I am confused as to why moderating her is not effective because I've forgotten she's in accept_these_nonmembers with an override.

Unmerged revisions

1360. By root <email address hidden> on 2012-07-06

Adds options to have the *_these_nonmembers override the posting rights of members included in *_these_nonmembers on a per list per *_these_nonmembers basis.

=== modified file 'Mailman/Gui/Privacy.py'
--- Mailman/Gui/Privacy.py	2009-01-11 16:06:13 +0000
+++ Mailman/Gui/Privacy.py	2012-07-06 17:31:20 +0000
@@ -253,6 +253,12 @@
              Mailman list in this installation, all of whose member
              addresses will be accepted for this list.""")),
 
+            ('accept_these_nonmembers_override', mm_cfg.Radio,
+              (_('No'), _('Yes')), 0,
+             _("""If a member is listed in accept_these_nonmembers their
+             postings will be automatically accepted regardless of their user
+             moderation status""")),
+
             ('hold_these_nonmembers', mm_cfg.EmailListEx, (10, WIDTH), 1,
              _("""List of non-member addresses whose postings will be
              immediately held for moderation."""),
@@ -264,6 +270,12 @@
              line; start the line with a ^ character to designate a regular
              expression match.""")),
 
+            ('hold_these_nonmembers_override', mm_cfg.Radio,
+              (_('No'), _('Yes')), 0,
+             _("""If a member is listed in hold_these_nonmembers their postings 
+             will be immedeiatly held for moderation regardless of their user
+             moderation status""")),
+
             ('reject_these_nonmembers', mm_cfg.EmailListEx, (10, WIDTH), 1,
              _("""List of non-member addresses whose postings will be
              automatically rejected."""),
@@ -279,6 +291,12 @@
              <p>Add member addresses one per line; start the line with a ^
              character to designate a regular expression match.""")),
 
+            ('reject_these_nonmembers_override', mm_cfg.Radio,
+              (_('No'), _('Yes')), 0,
+             _("""If a member is listed in reject_these_nonmembers their
+             postings will be automatically rejected regardless
+             of their user moderation status""")),
+
             ('discard_these_nonmembers', mm_cfg.EmailListEx, (10, WIDTH), 1,
              _("""List of non-member addresses whose postings will be
              automatically discarded."""),
@@ -293,6 +311,12 @@
              <p>Add member addresses one per line; start the line with a ^
              character to designate a regular expression match.""")),
 
+            ('discard_these_nonmembers_override', mm_cfg.Radio,
+              (_('No'), _('Yes')), 0,
+             _("""If a member is listed in discard_these_nonmembers their
+             postings will be automatically discarded regardless
+             of their user moderation status""")),
+
             ('generic_nonmember_action', mm_cfg.Radio,
              (_('Accept'), _('Hold'), _('Reject'), _('Discard')), 0,
              _("""Action to take for postings from non-members for which no
 
=== modified file 'Mailman/Handlers/Moderate.py'
--- Mailman/Handlers/Moderate.py	2011-01-25 01:16:17 +0000
+++ Mailman/Handlers/Moderate.py	2012-07-06 17:31:20 +0000
@@ -56,6 +56,22 @@
     else:
         sender = None
     if sender:
+        listname = mlist.internal_name()
+        if mlist.accept_these_nonmembers_override == 1:
+            if matches_p(sender, mlist.accept_these_nonmembers, listname):
+                return
+        if mlist.hold_these_nonmembers_override == 1:
+            if matches_p(sender, mlist.hold_these_nonmembers, listname):
+                Hold.hold_for_approval(mlist, msg, msgdata, Hold.NonMemberPost)
+                # No return
+        if mlist.reject_these_nonmembers_override == 1:
+            if matches_p(sender, mlist.reject_these_nonmembers, listname):
+                do_reject(mlist)
+                # No return
+        if mlist.discard_these_nonmembers_override == 1:
+            if matches_p(sender, mlist.discard_these_nonmembers, listname):
+                do_discard(mlist, msg)
+                # No return
         # If the member's moderation flag is on, then perform the moderation
         # action.
         if mlist.getMemberOption(sender, mm_cfg.Moderate):
 
=== modified file 'Mailman/MailList.py'
--- Mailman/MailList.py	2012-06-20 23:32:30 +0000
+++ Mailman/MailList.py	2012-07-06 17:31:20 +0000
@@ -388,6 +388,10 @@
         # 2==Discard
         self.member_moderation_action = 0
         self.member_moderation_notice = ''
+        self.accept_these_nonmembers_override = 0
+        self.hold_these_nonmembers_override = 0
+        self.reject_these_nonmembers_override = 0
+        self.discard_these_nonmembers_override = 0
         self.accept_these_nonmembers = []
         self.hold_these_nonmembers = []
         self.reject_these_nonmembers = []
 
=== modified file 'Mailman/Version.py'
--- Mailman/Version.py	2012-06-20 23:32:30 +0000
+++ Mailman/Version.py	2012-07-06 17:31:20 +0000
@@ -37,7 +37,7 @@
                (REL_LEVEL << 4)  | (REL_SERIAL << 0))
 
 # config.pck schema version number
-DATA_FILE_VERSION = 100
+DATA_FILE_VERSION = 101
 
 # qfile/*.db schema version number
 QFILE_SCHEMA_VERSION = 3
 
=== modified file 'Mailman/versions.py'
--- Mailman/versions.py	2012-06-20 23:32:30 +0000
+++ Mailman/versions.py	2012-07-06 17:31:20 +0000
@@ -93,6 +93,16 @@
         if not hasattr(l, newname) and newdefault is not uniqueval:
                 setattr(l, newname, newdefault)
 
+    # Patches for *_these_nonmembers_override
+    if not hasattr(l, 'accept_these_nonmembers_override'):
+        l.accept_these_nonmembers_override = 0
+    if not hasattr(l, 'hold_these_nonmembers_override'):
+        l.hold_these_nonmembers_override = 0
+    if not hasattr(l, 'reject_these_nonmembers_override'):
+        l.reject_these_nonmembers_override = 0
+    if not hasattr(l, 'discard_these_nonmembers_override'):
+        l.discard_these_nonmembers_override = 0
+
     # Migrate to 2.1b3, baw 17-Aug-2001
     if hasattr(l, 'dont_respond_to_post_requests'):
         oldval = getattr(l, 'dont_respond_to_post_requests')