Merge lp:~azzar1/unity/fix-868452-825037 into lp:unity
Proposed by
Andrea Azzarone
Status: | Merged |
---|---|
Approved by: | Andrea Azzarone |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1764 |
Proposed branch: | lp:~azzar1/unity/fix-868452-825037 |
Merge into: | lp:unity |
Diff against target: |
168 lines (+80/-13) 3 files modified
plugins/unityshell/src/BFBLauncherIcon.cpp (+66/-8) plugins/unityshell/src/BFBLauncherIcon.h (+11/-2) plugins/unityshell/src/DashView.cpp (+3/-3) |
To merge this branch: | bzr merge lp:~azzar1/unity/fix-868452-825037 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mirco Müller (community) | Approve | ||
Marco Trevisan (Treviño) | Approve | ||
Review via email: mp+83652@code.launchpad.net |
Description of the change
Display a list of the lenses in the bfb quicklist. It tries to fix bug #825037 too.
To post a comment you must log in.
It works as advertised, I guess this should be tested when autopilot is ready.
However, works well (fixes both the linked bugs) and the code looks good to me.
Just one thing, I guess that should be fixed at upper levels: replace_ all(name, "&", "&");
+ // "Files & folders", you are the culprit!
+ std::string name = lens->name();
+ boost::
Plus, if you open the dash, and you right-click on the BFB, all the quicklist items works, except the "Dash Home" item.