Code review comment for lp:~azzar1/unity/fix-868452-825037

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

It works as advertised, I guess this should be tested when autopilot is ready.

However, works well (fixes both the linked bugs) and the code looks good to me.

Just one thing, I guess that should be fixed at upper levels:
+ // "Files & folders", you are the culprit!
+ std::string name = lens->name();
+ boost::replace_all(name, "&", "&");

Plus, if you open the dash, and you right-click on the BFB, all the quicklist items works, except the "Dash Home" item.

review: Needs Fixing

« Back to merge proposal