Ubuntu UI Toolkit

Code review comment for lp:~zsombi/ubuntu-ui-toolkit/progressbar

  1. progressbar
  2. Merge into staging
Revision history for this message
Cris Dywan (kalikiana) wrote :

> > > + readonly property bool animateStrip:
> > Why || rather than && here?
> Good catch!! I was trying several things

You added the 'NumberAnimation on width' but that doesn't change the fact that animateStrip makes no sense - forgot to update it?

review: Needs Fixing

« Back to merge proposal