Merge lp:~zsombi/ubuntu-ui-toolkit/progressbar into lp:ubuntu-ui-toolkit/staging

[Zsombor Egri]

New visuals for ProgressBar

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

FAILED: Continuous integration, rev:2058
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1272/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5454/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1272/rebuild

review: Needs Fixing (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2058
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1036/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5457/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1036/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2058
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1285/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5458/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1285/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2058
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1069/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5459/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1069/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

FAILED: Continuous integration, rev:2058
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/671/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1272/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1285
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1069
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1036
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5460/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5454
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5458
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5459
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5457

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/671/rebuild

review: Needs Fixing (continuous-integration)

[Cris Dywan (kalikiana)]

+ Specifies if the value of the progress is visible. The current visuals in
+ Ubuntu Components 1.3 do not support this feature.
     */
    property bool showProgressPercentage: true

This seems to break behavior compatibility: any app that relies on the percentage will be lacking this detail.
And if new code doesn't set showProgressPercentage, like the example in the gallery, a later change in design would result in unexpected labels. So either the default should change to false to prevent this, or showProgressPercentage needs to be deprecated (short of that, we would need visuals so that developers can see that the property affects the component).

+ readonly property bool animateStrip:
+ (styledItem.enabled || styledItem.visible)

Why || rather than && here? What's the purpose of animating an enabled, !visible component?

review: Needs Information

[Zsombor Egri (zsombi)]

> + Specifies if the value of the progress is visible. The current visuals
> in
> + Ubuntu Components 1.3 do not support this feature.
> */
> property bool showProgressPercentage: true
>
> This seems to break behavior compatibility: any app that relies on the
> percentage will be lacking this detail.
> And if new code doesn't set showProgressPercentage, like the example in the
> gallery, a later change in design would result in unexpected labels. So either
> the default should change to false to prevent this, or showProgressPercentage
> needs to be deprecated (short of that, we would need visuals so that
> developers can see that the property affects the component).

I was thinking to keep the property as if someone wants to have visuals to support the value, they can be driven with it. But I am not strong against deprecating the property, this is typically one property which was introduced later and now we drop it... And it is not really an essential part of the ProgressBar API. But changing the default value is definitely a break, so we rather deprecate it.

>
> + readonly property bool animateStrip:
> + (styledItem.enabled || styledItem.visible)
>
> Why || rather than && here? What's the purpose of animating an enabled,
> !visible component?

Good catch!! I was trying several things to get the indeterminate acting properly, and seems I left the condition messed. So this is a needs fixing type :)

[lp:~zsombi/ubuntu-ui-toolkit/progressbar]

2060. By Zsombor Egri on 2016-08-29

staging sync

2061. By Zsombor Egri on 2016-08-29

animate value change on standard progress indication; deprecate showProgressPercentage property

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

FAILED: Continuous integration, rev:2061
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1315/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5642/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1315/rebuild

review: Needs Fixing (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2061
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1108/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5643/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1108/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2061
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1325/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5644/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1325/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2061
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1075/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5645/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1075/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

FAILED: Continuous integration, rev:2061
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/696/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1315/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1325
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1108
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1075
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5646/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5642
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5644
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5643
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5645

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/696/rebuild

review: Needs Fixing (continuous-integration)

[Timo Jyrinki (timo-jyrinki)]

Phone down, rerunning armhf only manually.

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2061
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1319/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5661/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1319/rebuild

review: Approve (continuous-integration)

[Cris Dywan (kalikiana)]

> > > + readonly property bool animateStrip:
> > Why || rather than && here?
> Good catch!! I was trying several things

You added the 'NumberAnimation on width' but that doesn't change the fact that animateStrip makes no sense - forgot to update it?

review: Needs Fixing

[Zsombor Egri (zsombi)]

> > > > + readonly property bool animateStrip:
> > > Why || rather than && here?
> > Good catch!! I was trying several things
>
> You added the 'NumberAnimation on width' but that doesn't change the fact that
> animateStrip makes no sense - forgot to update it?

CRAP, yes I did... :/

[lp:~zsombi/ubuntu-ui-toolkit/progressbar]

2062. By Zsombor Egri on 2016-09-07

fix indeterminate animation condition

2063. By Zsombor Egri on 2016-09-07

staging sync

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1144/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5907/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1144/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1110/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5913/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1110/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1360/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5915/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1360/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1353/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5917/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1353/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/718/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1353
        deb: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1353/artifact/artifacts/*zip*/artifacts.zip
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1360
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1144
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1110
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5918/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5917
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5915
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5907
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5913

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/718/rebuild

review: Approve (continuous-integration)

[Cris Dywan (kalikiana)]

> > You added the 'NumberAnimation on width' but that doesn't change the fact that
> > animateStrip makes no sense - forgot to update it?
> CRAP, yes I did... :/
Thanks!

review: Approve

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1156/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6146/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1156/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1122/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6153/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1122/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1372/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6154/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1372/rebuild

review: Approve (continuous-integration)

[ubuntu-sdk-build-bot (ubuntu-sdk-build-bot)]

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1365/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6155/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1365/rebuild

review: Approve (continuous-integration)

=== modified file 'examples/ubuntu-ui-toolkit-gallery/ProgressBars.qml'
--- examples/ubuntu-ui-toolkit-gallery/ProgressBars.qml	2015-04-25 08:18:45 +0000
+++ examples/ubuntu-ui-toolkit-gallery/ProgressBars.qml	2016-09-07 05:47:50 +0000
@@ -56,13 +56,13 @@
         }
 
         TemplateRow {
-            title: i18n.tr("No label")
+            title: progressTypeFlip.indeterminate ? i18n.tr("Infinite") : i18n.tr("Standard")
 
             ProgressBar {
-                id: progressNoLabel
+                id: progressTypeFlip
                 objectName: "progressbar_nolabel"
-                width: parent.width
-                showProgressPercentage: false
+                anchors.verticalCenter: parent.verticalCenter
+                width: parent.width - (switchBox.width + label.width + 2 * parent.spacing)
 
                 SequentialAnimation on value {
                     loops: Animation.Infinite
@@ -74,6 +74,15 @@
                     PauseAnimation {duration: 1000}
                 }
             }
+            Switch {
+                id: switchBox
+                checked: progressTypeFlip.indeterminate
+                onTriggered: progressTypeFlip.indeterminate = !progressTypeFlip.indeterminate
+            }
+            Label {
+                id: label
+                text: progressTypeFlip.indeterminate ? i18n.tr("to standard") : i18n.tr("to infinite")
+            }
         }
     }
 

=== modified file 'src/Ubuntu/Components/1.3/ProgressBar.qml'
--- src/Ubuntu/Components/1.3/ProgressBar.qml	2016-05-25 12:48:10 +0000
+++ src/Ubuntu/Components/1.3/ProgressBar.qml	2016-09-07 05:47:50 +0000
@@ -1,5 +1,5 @@
 /*
- * Copyright 2015 Canonical Ltd.
+ * Copyright 2015-2016 Canonical Ltd.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License as published by
@@ -66,7 +66,9 @@
 
     /*!
       \since Ubuntu.Components 1.1
-      Specifies if the value of the progress is visible
+      \deprecated
+      Specifies if the value of the progress is visible. The current visuals in
+      Ubuntu Components 1.3 do not support this feature.
     */
     property bool showProgressPercentage: true
 

=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/ProgressBarStyle.qml'
--- src/Ubuntu/Components/Themes/Ambiance/1.3/ProgressBarStyle.qml	2016-01-27 15:17:56 +0000
+++ src/Ubuntu/Components/Themes/Ambiance/1.3/ProgressBarStyle.qml	2016-09-07 05:47:50 +0000
@@ -1,5 +1,5 @@
 /*
- * Copyright 2015 Canonical Ltd.
+ * Copyright 2016 Canonical Ltd.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License as published by
@@ -17,67 +17,87 @@
 import QtQuick 2.4
 import Ubuntu.Components 1.3
 
-Item {
+Rectangle {
     id: progressBarStyle
 
     property color foregroundColor: styledItem.enabled
                                         ? theme.palette.normal.activity
                                         : theme.palette.disabled.activity
-    property color foregroundTextColor: styledItem.enabled
-                                            ? theme.palette.normal.activityText
-                                            : theme.palette.disabled.activityText
-    property color backgroundColor: styledItem.enabled
-                                        ? theme.palette.normal.base
-                                        : theme.palette.disabled.base
-    property color backgroundTextColor: styledItem.enabled
-                                            ? theme.palette.normal.baseText
-                                            : theme.palette.disabled.baseText
-
-    property var progressBar: styledItem
-
-    implicitWidth: units.gu(38)
-    implicitHeight: units.gu(4)
-
-    UbuntuShapeOverlay {
-        id: background
-        anchors.fill: parent
-        backgroundColor: progressBarStyle.backgroundColor
-        overlayColor: foregroundColor
-        overlayRect: Qt.application.layoutDirection == Qt.LeftToRight ?
-            Qt.rect(0.0, 0.0, progressBarStyle.progress, 1.0) :
-            Qt.rect(1.0 - progressBarStyle.progress, 0.0, 1.0, 1.0)
-    }
-
-    property real progress: progressBar.indeterminate ? 0.0
-                            : progressBar.value / (progressBar.maximumValue - progressBar.minimumValue)
-
-    Label {
-        id: valueLabel
-        anchors.centerIn: background
-        color: backgroundTextColor
-        text: progressBar.indeterminate ? i18n.dtr("ubuntu-ui-toolkit", "In Progress")
-              : "%1%".arg(Number(progressBarStyle.progress * 100.0).toFixed(0))
-        visible: !progressBar.hasOwnProperty("showProgressPercentage") || progressBar.showProgressPercentage
-
-        SequentialAnimation on opacity {
-            loops: Animation.Infinite
-            running: progressBar.indeterminate
-            UbuntuNumberAnimation {
-                to: 0.2; duration: UbuntuAnimation.BriskDuration
-            }
-            UbuntuNumberAnimation {
-                to: 1.0; duration: UbuntuAnimation.BriskDuration
-            }
-        }
-    }
-
-    PartialColorize {
-        anchors.fill: valueLabel
-        sourceItem: progressBar.indeterminate ? null : valueLabel
-        leftColor: foregroundTextColor
-        rightColor: backgroundTextColor
-        progress: (progressBarStyle.progress * background.width - valueLabel.x) / valueLabel.width
-        mirror: Qt.application.layoutDirection == Qt.RightToLeft
-        visible: !progressBar.hasOwnProperty("showProgressPercentage") || progressBar.showProgressPercentage
+    color: styledItem.enabled
+                ? theme.palette.normal.base
+                : theme.palette.disabled.base
+
+    implicitWidth: units.gu(36)
+    implicitHeight: units.gu(0.4)
+    clip: true
+
+    property real progress: styledItem.indeterminate ? 0.0
+                            : styledItem.value / (styledItem.maximumValue - styledItem.minimumValue)
+
+    Rectangle {
+        id: strip
+        anchors {
+            top: parent.top
+            left: !styledItem.indeterminate ? parent.left : undefined
+            bottom: parent.bottom
+        }
+        color: foregroundColor
+        width: styledItem.indeterminate
+                    ? MathUtils.clamp(parent.width / 4, units.gu(1), units.gu(30))
+                    : parent.width * progressBarStyle.progress
+
+        property int duration: UbuntuAnimation.SleepyDuration
+        property int easing: Easing.InOutQuad
+        readonly property bool animateStrip:
+            styledItem.enabled && styledItem.visible
+            && styledItem.indeterminate
+            // animate only after style completion!
+            && animated && !reverseAnimate
+        property bool reverseAnimate: false
+
+        NumberAnimation on width {
+            duration: UbuntuAnimation.SlowDuration
+            easing.type: strip.easing
+            running: !styledItem.indeterminate && styledItem.enabled && styledItem.visible
+        }
+
+        state: animateStrip ? "animate" : ""
+
+        // reversible doesn't work, so we need animatiomns for both transitions
+        // note: we cannot use XAnimator as there will be a point when
+        // there will be two animators altering (running) the x property at the
+        // same time, which causes SIGSEG
+        transitions: [
+            Transition {
+                from: ""
+                to: "animate"
+                SequentialAnimation {
+                    NumberAnimation {
+                        target: strip
+                        property: "x"
+                        duration: strip.duration
+                        easing.type: strip.easing
+                        from: -strip.width
+                        to: progressBarStyle.width
+                    }
+                    ScriptAction { script: strip.reverseAnimate = true; }
+                }
+            },
+            Transition {
+                from: "animate"
+                to: ""
+                SequentialAnimation {
+                    NumberAnimation {
+                        target: strip
+                        property: "x"
+                        duration: strip.duration
+                        easing.type: strip.easing
+                        to: -strip.width
+                        from: progressBarStyle.width
+                    }
+                    ScriptAction { script: strip.reverseAnimate = false; }
+                }
+            }
+        ]
     }
 }