Code review comment for lp:~zsombi/ubuntu-ui-toolkit/app-theming

Revision history for this message
Cris Dywan (kalikiana) wrote :

I like it. Not only is the binding loop gone, the colors are also applied consistently on start-up as well as later at runtime.

One thing: the example like that won't be easily importable into QtCreator. But no reason to block on that, to be honest we're not having much of a policy with regard to that anyway and it'll need more discussion.

review: Approve

« Back to merge proposal