lp:~zsombi/ubuntu-ui-toolkit/app-theming

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:ubuntu-ui-toolkit/rtm

Tim Peeters: Approve (quick look) on 2014-11-28

Cris Dywan: Approve on 2014-11-27

Diff: 529 lines (+370/-21)

16 files modified

examples/customtheme/customtheme.apparmor (+8/-0)
examples/customtheme/customtheme.desktop (+8/-0)
examples/customtheme/customtheme.qmlproject (+59/-0)
examples/customtheme/main.qml (+103/-0)
examples/customtheme/manifest.json (+15/-0)
examples/customtheme/theme/Palette.qml (+24/-0)
examples/customtheme/theme/parent_theme (+1/-0)
modules/Ubuntu/Components/MainView.qml (+16/-0)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+0/-17)
modules/Ubuntu/Components/plugin/uctheme.cpp (+4/-2)
tests/unit_x11/tst_components/tst_theming.qml (+60/-0)
tests/unit_x11/tst_theme_engine/AppTheme/Palette.qml (+24/-0)
tests/unit_x11/tst_theme_engine/AppTheme/parent_theme (+1/-0)
tests/unit_x11/tst_theme_engine/TestApp.qml (+29/-0)
tests/unit_x11/tst_theme_engine/tst_theme_engine.pro (+3/-1)
tests/unit_x11/tst_theme_engine/tst_theme_enginetest.cpp (+15/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1213043: Binding loop detected when changing backgroundColor of MainView dynamically	High	Fix Released
Bug #1277647: Changing theme from Ambiance to SuruDark or SuruGradient in MainView's completion causes binding loops.	Undecided	Fix Released
Bug #1330510: Valgrind warning when theme is changed from MainViewStyle.qml	High	Fix Released
Bug #1356779: [SDK] MainView.backgroundColor is not usable any more	High	Fix Released
Bug #1389792: theme not found when using a user-defined theme	High	Fix Released

Link a bug report

Related blueprints

1134. By Zsombor Egri on 2014-12-03

roll back unnecessary change on theme not found warning

1133. By Zsombor Egri on 2014-11-27

more tests added

1132. By Zsombor Egri on 2014-11-27

fixing application theme loading; automatic theme change from style transferred to MainView and made system theme dependent, fixed binding loops and ones detected by Valgrind, also causing application themes to be discarded.

1131. By Zoltan Balogh on 2014-11-13

Fixed unit test tst_components::tst_textinput_touch::test_longtap_when_empty: do not cause a double tap before the long press.

1130. By Zoltan Balogh on 2014-11-12

Fixed changelog

1129. By Zoltan Balogh on 2014-11-12

Fixed changelog

1128. By Zoltan Balogh on 2014-11-12

Revert the revert. Now the MR's branch must be on top

1127. By Zoltan Balogh on 2014-11-12

Fixed changelog

1126. By Zoltan Balogh on 2014-11-12

Revert to 1124

1125. By Zoltan Balogh on 2014-11-12

Many TextField/TextArea fixes improving user experience greatly and making it more in line with the design: handle much easier to drag by making its touch area 4 grid units wide and centered around the cursor; double tapping anywhere (even around the handle) selects the word and opens the contextual menu; long pressing anywhere (even around the handle) selects the word and opens the contextual menu; make sure that when there is a selection the contextual menu is shown and shown above the cursor at the beginning of the selection; do not prevent other UI elements from receiving mouse/touch events when the contextual menu is shown