Merge lp:~zorba-coders/zorba/util-jvm-module-bug1006311 into lp:zorba/util-jvm-module

Proposed by Juan Zacarias
Status: Merged
Approved by: Juan Zacarias
Approved revision: 14
Merged at revision: 16
Proposed branch: lp:~zorba-coders/zorba/util-jvm-module-bug1006311
Merge into: lp:zorba/util-jvm-module
Diff against target: 45 lines (+7/-7)
2 files modified
CMakeLists.txt (+5/-5)
cmake_modules/Windows/FindJNI.cmake (+2/-2)
To merge this branch: bzr merge lp:~zorba-coders/zorba/util-jvm-module-bug1006311
Reviewer Review Type Date Requested Status
Juan Zacarias Approve
Chris Hillery Approve
Review via email: mp+118647@code.launchpad.net

Commit message

Fix for bug 1006311
Changed CMakeLists.txt file to look first for zorba and then add the cmake_module directory correctly so the module takes into account looking for the jvm.dll

To post a comment you must log in.
Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Juan Zacarias (juan457) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job util-jvm-module-bug1006311-2012-09-20T19-15-44.132Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2012-07-24 20:29:24 +0000
+++ CMakeLists.txt 2012-08-07 23:13:20 +0000
@@ -24,6 +24,11 @@
24 MESSAGE(STATUS "")24 MESSAGE(STATUS "")
25 MESSAGE(STATUS "--- Module: util-jvm ---")25 MESSAGE(STATUS "--- Module: util-jvm ---")
2626
27 FIND_PACKAGE (Zorba REQUIRED HINTS "${ZORBA_BUILD_DIR}")
28 INCLUDE ("${Zorba_USE_FILE}")
29
30 SET_CMAKE_MODULE_PATH()
31
27 MESSAGE (STATUS "Looking for JNI")32 MESSAGE (STATUS "Looking for JNI")
28 ZORBA_FIND_JNI()33 ZORBA_FIND_JNI()
2934
@@ -32,11 +37,6 @@
3237
33 IF (JNI_FOUND)38 IF (JNI_FOUND)
34 SET (UTIL_JVM_VERSION 1.0)39 SET (UTIL_JVM_VERSION 1.0)
35
36 FIND_PACKAGE (Zorba REQUIRED HINTS "${ZORBA_BUILD_DIR}")
37 INCLUDE ("${Zorba_USE_FILE}")
38
39 SET_CMAKE_MODULE_PATH()
40 40
41 # Export this include directory by setting ZORBA_PROJECT_INCLUDE_DIRS41 # Export this include directory by setting ZORBA_PROJECT_INCLUDE_DIRS
42 SET (ZORBA_PROJECT_INCLUDE_DIRS "${CMAKE_CURRENT_SOURCE_DIR}/include")42 SET (ZORBA_PROJECT_INCLUDE_DIRS "${CMAKE_CURRENT_SOURCE_DIR}/include")
4343
=== modified file 'cmake_modules/Windows/FindJNI.cmake'
--- cmake_modules/Windows/FindJNI.cmake 2012-07-02 10:52:42 +0000
+++ cmake_modules/Windows/FindJNI.cmake 2012-08-07 23:13:20 +0000
@@ -25,11 +25,11 @@
25 IF (EXISTS "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/client")25 IF (EXISTS "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/client")
26 SET (FOUND_LOCATION "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/client")26 SET (FOUND_LOCATION "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/client")
27 # find the needed DLL's27 # find the needed DLL's
28 FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "jvm")28 FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "jvm" SKIP_INSTALL)
29 ELSEIF (EXISTS "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/server")29 ELSEIF (EXISTS "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/server")
30 SET (FOUND_LOCATION "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/server")30 SET (FOUND_LOCATION "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/server")
31 # find the needed DLL's31 # find the needed DLL's
32 FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "jvm")32 FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "jvm" SKIP_INSTALL)
33 ELSE (EXISTS "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/client")33 ELSE (EXISTS "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/client")
34 MESSAGE (WARNING "Could not find the jvm.dll for the JVM library: ${JAVA_JVM_LIBRARY}. Please extend this module to find the jvm.dll somewhere in your JVM directory or make sure that jvm.dll is in the PATH.")34 MESSAGE (WARNING "Could not find the jvm.dll for the JVM library: ${JAVA_JVM_LIBRARY}. Please extend this module to find the jvm.dll somewhere in your JVM directory or make sure that jvm.dll is in the PATH.")
35 ENDIF (EXISTS "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/client")35 ENDIF (EXISTS "${JAVA_JVM_LIBRARY_PATH}/../jre/bin/client")

Subscribers

People subscribed via source and target branches

to all changes: