Zorba

jvm.dll not found under Windows when using util-jvm

Bug #1006311 reported by Ghislain Fourny
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zorba
Fix Released
Critical
Juan Zacarias
Zorba 2.9 "Io"

Bug Description

Under Windows, launching Zorba with a query that uses the util-jvm module (for example through data-formatting) leads to an error message (jvm.dll not found).

This is possibly because %JAVA_HOME%\jre\bin\client is not added to the PATH.

Related branches

lp:~zorba-coders/zorba/util-jvm-module-bug1006311
Juan Zacarias: Approve
Chris Hillery: Approve
Diff: 45 lines (+7/-7)
2 files modified
CMakeLists.txt (+5/-5)
cmake_modules/Windows/FindJNI.cmake (+2/-2)
lp:~zorba-coders/zorba/zorba-bug1006311
Chris Hillery: Approve
Juan Zacarias: Approve
Diff: 48 lines (+14/-7)
1 file modified
cmake_modules/Windows/ProxyFindModule.cmake (+14/-7)
Revision history for this message
Chris Hillery (ceejatec) wrote :

It's up to the user to make sure their PATH is correct on Windows, isn't it?

I guess zorba.bat (and testdriver.bat) could be modified to include the path to the JVM, but that would require moving some Java-specific code into the core of Zorba. Currently all Java-specific stuff is isolated in the util-jvm module, but I'd thought about moving it into core Zorba after this release anyway.

Regardless, I'm afraid I have no way of modifying or testing the .bat files. Assigning this to Juan, and subscribing Matthias to see if he has any thoughts about what the right answer is.

Changed in zorba:
assignee: Chris Hillery (ceejatec) → Juan Zacarias (juan457)
Dana Florescu (dflorescu)
Changed in zorba:
importance: Undecided → Critical
Juan Zacarias (juan457)
Changed in zorba:
status: New → Fix Committed
status: Fix Committed → New
Revision history for this message
Juan Zacarias (juan457) wrote :

Yes that's true is responsibility of the user to do this, Actually for the installer I do just this, just if someone could answer me what is the file responsible for creating the zorba.bat?

Revision history for this message
Juan Zacarias (juan457) wrote :

The fix was actually quit simple.

The problem was that the cmake_module/Window/FindJNI.cmake wasnt running because SET_CMAKE_MODULE_PATH() was not being running before looking for JNI so the FIND_PACKAGE_DLL_WIN32 macro was not running. This macro is the one that adds the path of the dlls to the .bat files, and because it was not running, it was not adding the path of jvm.dll to the bat file of zorba.

A problem with fixing this, is that the FIND_PACKAGE_DLL_WIN32 macro also installs the dll so I made changes to avoid installation of the dll when specified.

Dana Florescu (dflorescu)
Changed in zorba:
milestone: none → 2.8
Juan Zacarias (juan457)
Changed in zorba:
status: New → Fix Committed
Dana Florescu (dflorescu)
Changed in zorba:
milestone: 2.8 → 2.9
Chris Hillery (ceejatec)
Changed in zorba:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.