Merge ~ycheng-twn/plainbox-provider-resource:0001_use_hex_in_vid_pid into plainbox-provider-resource:master

[Yuan-Chen Cheng]

per test, the value type int have the following attribute:

product_id:
subproduct_id:
subvendor_id:
vendor_id:

For above id, hex is the preferred format.

[Jonathan Cave (jocave)]

It's not obvious to me whether this might break filters applied in providers - I would hope that any comparisons are made based on the numerical value rather than a string, but I wouldn't guarantee it.

This needs to be checked before it can land.

review: Needs Information

[Yuan-Chen Cheng (ycheng-twn)]

Sorry I don't know what exactly the test case I should go through.

Will it be accepted if hex is output only if some command line option is applied?

like --hex maybe?

[Jonathan Cave (jocave)]

It would be necessary to check all job definitions in all providers that use this resource.

I quick grep through all the git repositories I have cloned reveals lines like:

checkbox-provider-mcp2210/units/jobs.pxu:
template-filter: device.category == 'HIDRAW' and device.vendor_id == '1240' and device.product_id == '222'

This is a string comparison that would be broken by this change and would have to be modified. Hence, at this point I'm -1

review: Disapprove

Unmerged commits

b110cd1... by Yuan-Chen Cheng on 2020-08-10

output hex for vid and pid

Signed-off-by: Yuan-Chen Cheng <email address hidden>

diff --git a/bin/udev_resource.py b/bin/udev_resource.py
index b18e085..688a924 100755
--- a/bin/udev_resource.py
+++ b/bin/udev_resource.py
@@ -37,13 +37,22 @@ attributes = ("path", "name", "bus", "category", "driver", "product_id",
               "symlink_uuid")
 
 
-class UdevResultDump:
+def format_attr_val(attr, val):
+    fmt = "{}: {}"
+    if isinstance(val, int):
+        if (val < 0x10000):
+            fmt = "{}: 0x{:04x}"
+        else: # defensive code
+            fmt = "{}: 0x{:08x}"
+    return fmt.format(attr, val)
+
 
+class UdevResultDump:
     def addDevice(self, device):
         for attribute in attributes:
             value = getattr(device, attribute)
             if value is not None:
-                print("%s: %s" % (attribute, value))
+                print(format_attr_val(attribute, value))
         print()
 
 
@@ -77,7 +86,7 @@ class UdevResultLister:
             for attribute in attributes:
                 value = getattr(device, attribute)
                 if value is not None:
-                    print("%s: %s" % (attribute, value))
+                    print(format_attr_val(attribute, value))
             print()
 
     def addDevice(self, device):