Code review comment for ~ycheng-twn/plainbox-provider-resource:0001_use_hex_in_vid_pid

Revision history for this message
Jonathan Cave (jocave) wrote :

It would be necessary to check all job definitions in all providers that use this resource.

I quick grep through all the git repositories I have cloned reveals lines like:

checkbox-provider-mcp2210/units/jobs.pxu:
template-filter: device.category == 'HIDRAW' and device.vendor_id == '1240' and device.product_id == '222'

This is a string comparison that would be broken by this change and would have to be modified. Hence, at this point I'm -1

review: Disapprove

« Back to merge proposal