Merge ~ycheng-twn/plainbox-provider-resource:0001_use_hex_in_vid_pid into plainbox-provider-resource:master
Proposed by
Yuan-Chen Cheng
Status: | Rejected |
---|---|
Rejected by: | Sylvain Pineau |
Proposed branch: | ~ycheng-twn/plainbox-provider-resource:0001_use_hex_in_vid_pid |
Merge into: | plainbox-provider-resource:master |
Diff against target: |
38 lines (+12/-3) 1 file modified
bin/udev_resource.py (+12/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonathan Cave (community) | Disapprove | ||
Review via email: mp+388983@code.launchpad.net |
Commit message
per test, the value type int have the following attribute:
product_id:
subproduct_id:
subvendor_id:
vendor_id:
For above id, hex is the preferred format.
To post a comment you must log in.
It's not obvious to me whether this might break filters applied in providers - I would hope that any comparisons are made based on the numerical value rather than a string, but I wouldn't guarantee it.
This needs to be checked before it can land.