Merge lp:~ya-bo-ng/ubuntu-manpage-repository/1783869-fix-pre-styling into lp:ubuntu-manpage-repository

Proposed by Anthony Dillon
Status: Merged
Approved by: David Britton
Approved revision: 224
Merged at revision: 224
Proposed branch: lp:~ya-bo-ng/ubuntu-manpage-repository/1783869-fix-pre-styling
Merge into: lp:ubuntu-manpage-repository
Diff against target: 12 lines (+2/-0)
1 file modified
www/assets/light/css/styles.css (+2/-0)
To merge this branch: bzr merge lp:~ya-bo-ng/ubuntu-manpage-repository/1783869-fix-pre-styling
Reviewer Review Type Date Requested Status
David Britton Approve
Review via email: mp+351432@code.launchpad.net

Commit message

LP: #1783869 - Fix the pre formatting

Description of the change

Add pre formatting to pre elements and made them scrollable when the content does not fit.

To post a comment you must log in.
Revision history for this message
David Britton (dpb) wrote :

Hi Ant, I think it has improved the situation, but I think there is still a couple things that would be nice to see.

Could we give the whole page a minimum fixed width, and not each individual section? If perhaps we put <pre> tags around the whole thing?

e.g., http://man7.org/linux/man-pages/man1/ac.1.html

I took this screenshot showing the jaggedness of having each section broken up

https://i.imgur.com/CB4X61f.png

Also, each section has a border even if it's not scrollable, which looks a bit wonky.

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Thanks for the feedback David. Might be worth getting this change landed
and live? Then I can ask one of our designers to redesign the site.

On Fri, 27 Jul 2018, 17:59 David Britton, <email address hidden>
wrote:

> Hi Ant, I think it has improved the situation, but I think there is still
> a couple things that would be nice to see.
>
> Could we give the whole page a minimum fixed width, and not each
> individual section? If perhaps we put <pre> tags around the whole thing?
>
> e.g., http://man7.org/linux/man-pages/man1/ac.1.html
>
> I took this screenshot showing the jaggedness of having each section
> broken up
>
> https://i.imgur.com/CB4X61f.png
>
> Also, each section has a border even if it's not scrollable, which looks a
> bit wonky.
>
> --
>
> https://code.launchpad.net/~ya-bo-ng/ubuntu-manpage-repository/1783869-fix-pre-styling/+merge/351432
> You are the owner of
> lp:~ya-bo-ng/ubuntu-manpage-repository/1783869-fix-pre-styling.
>
> Launchpad-Message-Rationale: Owner
> Launchpad-Message-For: ya-bo-ng
> Launchpad-Notification-Type: code-review
> Launchpad-Branch:
> ~ya-bo-ng/ubuntu-manpage-repository/1783869-fix-pre-styling
> Launchpad-Project: ubuntu-manpage-repository
>

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Hi all, do you feel we could land this fix and have the pages designed in the near future?

Revision history for this message
David Britton (dpb) wrote :

AFter consulting with Josh, we are agreed that this is an improvement to narrow windows while a re-design is in progress. Thanks for the fix Anthony.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'www/assets/light/css/styles.css'
--- www/assets/light/css/styles.css 2018-07-19 14:07:57 +0000
+++ www/assets/light/css/styles.css 2018-07-27 16:21:50 +0000
@@ -4,6 +4,8 @@
44
5pre {5pre {
6 font-size: .875rem;6 font-size: .875rem;
7 overflow: scroll;
8 white-space: pre;
7}9}
810
9.row {11.row {

Subscribers

People subscribed via source and target branches