Code review comment for lp:~ya-bo-ng/ubuntu-manpage-repository/1783869-fix-pre-styling

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Thanks for the feedback David. Might be worth getting this change landed
and live? Then I can ask one of our designers to redesign the site.

On Fri, 27 Jul 2018, 17:59 David Britton, <email address hidden>
wrote:

> Hi Ant, I think it has improved the situation, but I think there is still
> a couple things that would be nice to see.
>
> Could we give the whole page a minimum fixed width, and not each
> individual section? If perhaps we put <pre> tags around the whole thing?
>
> e.g., http://man7.org/linux/man-pages/man1/ac.1.html
>
> I took this screenshot showing the jaggedness of having each section
> broken up
>
> https://i.imgur.com/CB4X61f.png
>
> Also, each section has a border even if it's not scrollable, which looks a
> bit wonky.
>
> --
>
> https://code.launchpad.net/~ya-bo-ng/ubuntu-manpage-repository/1783869-fix-pre-styling/+merge/351432
> You are the owner of
> lp:~ya-bo-ng/ubuntu-manpage-repository/1783869-fix-pre-styling.
>
> Launchpad-Message-Rationale: Owner
> Launchpad-Message-For: ya-bo-ng
> Launchpad-Notification-Type: code-review
> Launchpad-Branch:
> ~ya-bo-ng/ubuntu-manpage-repository/1783869-fix-pre-styling
> Launchpad-Project: ubuntu-manpage-repository
>

« Back to merge proposal