Merge ~ya-bo-ng/maas:call-out-default into maas:master

Proposed by Anthony Dillon
Status: Merged
Approved by: Anthony Dillon
Approved revision: b683fabb01357a0797e3016b3ae9fe8cae368dd4
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ya-bo-ng/maas:call-out-default
Merge into: maas:master
Diff against target: 37 lines (+5/-5)
1 file modified
src/maasserver/static/partials/pod-details.html (+5/-5)
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Caleb Ellis (community) Approve
Review via email: mp+355739@code.launchpad.net

Commit message

Mark the default storage pools when composing a machine

Description of the change

When composing a machine in a pod the selection of storage pools now has (default) appended to the name of the storage pool.

Screenshot: https://screenshots.firefox.com/JljoupqiMZ7fPBij/10.54.72.65

To post a comment you must log in.
Revision history for this message
Caleb Ellis (caleb-ellis) wrote :

Code lgtm +1

review: Approve
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/src/maasserver/static/partials/pod-details.html b/src/maasserver/static/partials/pod-details.html
index 00ac64b..20a92a3 100644
--- a/src/maasserver/static/partials/pod-details.html
+++ b/src/maasserver/static/partials/pod-details.html
@@ -208,7 +208,7 @@
208 tabindex="0"208 tabindex="0"
209 ng-repeat="storage_pool in pod.storage_pools" ng-click="selectStoragePool(storage_pool, storage)" ng-keyup="$event.keyCode == 13 ? selectStoragePool(storage_pool, storage) : null" ng-class="{'is-selected': storage.pool === storage_pool}">209 ng-repeat="storage_pool in pod.storage_pools" ng-click="selectStoragePool(storage_pool, storage)" ng-keyup="$event.keyCode == 13 ? selectStoragePool(storage_pool, storage) : null" ng-class="{'is-selected': storage.pool === storage_pool}">
210 <div class="p-option-selector__option-cell">210 <div class="p-option-selector__option-cell">
211 <div><strong>{$ storage_pool.name $}</strong></div>211 <div><strong>{$ storage_pool.name $} <span data-ng-if="pod.default_storage_pool == storage_pool.id">(default)</span></strong></div>
212 <div class="u-text--light">{$ storage_pool.path $}</div>212 <div class="u-text--light">{$ storage_pool.path $}</div>
213 </div>213 </div>
214 <div class="p-option-selector__option-cell u-align--right">214 <div class="p-option-selector__option-cell u-align--right">
@@ -398,8 +398,8 @@
398 </span>398 </span>
399 </p>399 </p>
400 <div class="p-storage__info">400 <div class="p-storage__info">
401 <p class="p-storage__type">{$ storage.type $}<br>401 <p class="p-storage__type">{$ storage.type | formatStorageType $}<br>
402 <span class="p-storage__size">{$ storage.total $}</span>402 <span class="p-storage__size">{$ storage.total | formatBytes $}</span>
403 </p>403 </p>
404 </div>404 </div>
405 </div>405 </div>
@@ -413,10 +413,10 @@
413 </div>413 </div>
414 <div class="p-legend--numbers u-clearfix">414 <div class="p-legend--numbers u-clearfix">
415 <span class="p-legend__text default-text u-float--left">415 <span class="p-legend__text default-text u-float--left">
416 {$ storage.available $}416 {$ storage.available | formatBytes $}
417 </span>417 </span>
418 <span class="p-legend__text default-text u-float--right">418 <span class="p-legend__text default-text u-float--right">
419 {$ storage.used $}419 {$ storage.used | formatBytes $}
420 </span>420 </span>
421 </div>421 </div>
422 </div>422 </div>

Subscribers

People subscribed via source and target branches