Merge ~ya-bo-ng/maas:call-out-default into maas:master

Proposed by Anthony Dillon
Status: Merged
Approved by: Anthony Dillon
Approved revision: b683fabb01357a0797e3016b3ae9fe8cae368dd4
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ya-bo-ng/maas:call-out-default
Merge into: maas:master
Diff against target: 37 lines (+5/-5)
1 file modified
src/maasserver/static/partials/pod-details.html (+5/-5)
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Caleb Ellis (community) Approve
Review via email: mp+355739@code.launchpad.net

Commit message

Mark the default storage pools when composing a machine

Description of the change

When composing a machine in a pod the selection of storage pools now has (default) appended to the name of the storage pool.

Screenshot: https://screenshots.firefox.com/JljoupqiMZ7fPBij/10.54.72.65

To post a comment you must log in.
Revision history for this message
Caleb Ellis (caleb-ellis) wrote :

Code lgtm +1

review: Approve
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/partials/pod-details.html b/src/maasserver/static/partials/pod-details.html
2index 00ac64b..20a92a3 100644
3--- a/src/maasserver/static/partials/pod-details.html
4+++ b/src/maasserver/static/partials/pod-details.html
5@@ -208,7 +208,7 @@
6 tabindex="0"
7 ng-repeat="storage_pool in pod.storage_pools" ng-click="selectStoragePool(storage_pool, storage)" ng-keyup="$event.keyCode == 13 ? selectStoragePool(storage_pool, storage) : null" ng-class="{'is-selected': storage.pool === storage_pool}">
8 <div class="p-option-selector__option-cell">
9- <div><strong>{$ storage_pool.name $}</strong></div>
10+ <div><strong>{$ storage_pool.name $} <span data-ng-if="pod.default_storage_pool == storage_pool.id">(default)</span></strong></div>
11 <div class="u-text--light">{$ storage_pool.path $}</div>
12 </div>
13 <div class="p-option-selector__option-cell u-align--right">
14@@ -398,8 +398,8 @@
15 </span>
16 </p>
17 <div class="p-storage__info">
18- <p class="p-storage__type">{$ storage.type $}<br>
19- <span class="p-storage__size">{$ storage.total $}</span>
20+ <p class="p-storage__type">{$ storage.type | formatStorageType $}<br>
21+ <span class="p-storage__size">{$ storage.total | formatBytes $}</span>
22 </p>
23 </div>
24 </div>
25@@ -413,10 +413,10 @@
26 </div>
27 <div class="p-legend--numbers u-clearfix">
28 <span class="p-legend__text default-text u-float--left">
29- {$ storage.available $}
30+ {$ storage.available | formatBytes $}
31 </span>
32 <span class="p-legend__text default-text u-float--right">
33- {$ storage.used $}
34+ {$ storage.used | formatBytes $}
35 </span>
36 </div>
37 </div>

Subscribers

People subscribed via source and target branches