Merge ~ya-bo-ng/maas:add-dhcp-snippets-empty-state into maas:master

[Anthony Dillon]

Add an empty state to the settings DHCP snippets

Add logic to the DHCP snippets table which displays a message when there are none.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b add-dhcp-snippets-empty-state lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 0d12f2010d744ded8e682d7efe5cd7119cc1ea91

review: Approve

[Blake Rouse (blake-rouse)]

Looks good.

review: Approve

diff --git a/src/maasserver/static/partials/settings.html b/src/maasserver/static/partials/settings.html
index 1a6ca98..d471186 100644
--- a/src/maasserver/static/partials/settings.html
+++ b/src/maasserver/static/partials/settings.html
@@ -58,6 +58,11 @@
                     </tr>
                 </thead>
                 <tbody>
+                    <tr data-ng-if="snippets.length === 0">
+                        <td colspan="5">
+                            No DHCP snippets available
+                        </td>
+                    </tr>
                     <tr data-ng-repeat="snippet in snippets track by snippet.id"
                         data-ng-class="{ 'is-active': editSnippet === snippet || deleteSnippet === snippet }">
                         <td class="col-2" aria-label="Name" data-ng-if="editSnippet !== snippet">
@@ -200,11 +205,11 @@
                                         <label for="subnet" class="u-hide u-show--small" data-ng-if="newSnippet.$maasForm.getValue('type') === 'Subnet'">Choose subnet</label>
                                         <label for="node" class="u-hide u-show--small" data-ng-if="newSnippet.$maasForm.getValue('type') === 'Node'">Choose node</label>
                                         <maas-obj-field type="options" key="subnet" placeholder="Choose subnet"
-                                            disable-label="true" input-class="table__input"
+                                            disable-label="true" input-class="table__input" class="u-no-margin--top"
                                             options="subnet.id as getSubnetName(subnet) for subnet in subnets"
                                             data-ng-if="newSnippet.$maasForm.getValue('type') === 'Subnet'"></maas-obj-field>
                                         <maas-obj-field type="options" key="node" placeholder="Choose node"
-                                            disable-label="true" input-class="table__input"
+                                            disable-label="true" input-class="table__input" class="u-no-margin--top"
                                             options="node.system_id as node.fqdn group by node.node_type_display for node in machines.concat(devices).concat(controllers)"
                                             data-ng-if="newSnippet.$maasForm.getValue('type') === 'Node'">
                                         </maas-obj-field>