Code review comment for lp:~xnox/ubuntu-cdimage/generic-preinstalled

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

Ok, so even though this would indeed make the end images not have 'generic' in the name, I thought Steve wanted not to use SUBARCH at all for these preinstalled images? Since yeah, if it's just about the naming, we can go ahead.

Steve, was it only the naming you were interested in? Or in the way we build the images?

That being said, I *personally* am not a big fan of such implicit transformations, so if it was about me I'd either stick with 'generic' in the name or revamp livecd-rootfs+cdimage to not use SUBARCH for building the preinstalled amd64/arm64 images (which was my original intention when taking the card). The whole livecd-rootfs and ubuntu-cdimage story is already confusing enough, requiring quirk knowledge (like, ubuntu-server preinstalled using ubuntu-cpc as the project etc.). Yet another hidden translation like this feels unnecessary.

I have started working on a branch that would add such images using the 'new way' of preinstalled image building, so with IMAGEFORMAT=ubuntu-image. I'd like us to use ubuntu-image as much as possible as currently right now it's only used for the pi's.

review: Needs Information

« Back to merge proposal