Merge lp:~xnox/ubuntu-cdimage/generic-preinstalled into lp:ubuntu-cdimage

Proposed by Dimitri John Ledkov
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 1947
Merged at revision: 1950
Proposed branch: lp:~xnox/ubuntu-cdimage/generic-preinstalled
Merge into: lp:ubuntu-cdimage
Diff against target: 26 lines (+4/-1)
2 files modified
etc/default-arches (+2/-1)
etc/qa-products (+2/-0)
To merge this branch: bzr merge lp:~xnox/ubuntu-cdimage/generic-preinstalled
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Steve Langasek Needs Fixing
Ubuntu CD Image Team Pending
Review via email: mp+401223@code.launchpad.net

Commit message

Provide generic preinstalled images for arm64, amd64

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Doing test builds with this in a PPA for testing.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

===== Building live filesystems =====
Thu Apr 15 14:24:11 UTC 2021
ubuntu-server-armhf-raspi on Launchpad starting at 2021-04-15 15:24:11
ubuntu-server-armhf-raspi: https://launchpad.net/~xnox/+livefs/ubuntu/hirsute/any-devirt/+build/271078
ubuntu-server-arm64-raspi on Launchpad starting at 2021-04-15 15:24:14
ubuntu-server-arm64-raspi: https://launchpad.net/~xnox/+livefs/ubuntu/hirsute/any-devirt/+build/271079
ubuntu-server-riscv64-sifive_fu540 on Launchpad starting at 2021-04-15 15:24:15
ubuntu-server-riscv64-sifive_fu540: https://launchpad.net/~xnox/+livefs/ubuntu/hirsute/any-devirt/+build/271080
ubuntu-server-riscv64-sifive_hifive_unmatched_fu740 on Launchpad starting at 2021-04-15 15:24:17
ubuntu-server-riscv64-sifive_hifive_unmatched_fu740: https://launchpad.net/~xnox/+livefs/ubuntu/hirsute/any-devirt/+build/271081
ubuntu-server-amd64-generic on Launchpad starting at 2021-04-15 15:24:17
ubuntu-server-amd64-generic: https://launchpad.net/~xnox/+livefs/ubuntu/hirsute/any-devirt/+build/271082
ubuntu-server-arm64-generic on Launchpad starting at 2021-04-15 15:24:18
ubuntu-server-arm64-generic: https://launchpad.net/~xnox/+livefs/ubuntu/hirsute/any-devirt/+build/271083

Pending.

launched with:

EXTRA_PPAS=xnox/nonvirt DIST=hirsute for-project ubuntu-server cron.daily-preinstalled --live

updated PPA has updated livecd-rootfs.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

and those builds are all stuck. Will retry again.

1941. By Łukasz Zemczak

hirsute -> impish

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

ping! Rebased this on top of current ubuntu-cdimage, livecd-rootfs has migrated to impish release. So this is ready to be deployed.

1942. By Łukasz Zemczak

Add the image archival helper script.

1943. By Łukasz Zemczak

Add proper usage display.

1944. By Łukasz Zemczak

Use the real directory paths.

1945. By Łukasz Zemczak

archive-image: minor cleanup, support empty-flavor full images.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

ping!

Revision history for this message
Steve Langasek (vorlon) :
review: Needs Information
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Generally this seems right. So LGTM. But if Steve thinks that a SUBARCH is not needed, maybe that's something worth changing still.

Revision history for this message
Dimitri John Ledkov (xnox) :
Revision history for this message
Steve Langasek (vorlon) :
review: Needs Fixing
1946. By Steve Langasek

Merge lp:~krytarik/ubuntu-cdimage/flavor-assets

1947. By Dimitri John Ledkov

Enable Ubuntu Server daily-preinstalled amd64 & arm64 images.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

1)

Please edit
https://code.launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/impish/cpc and change metadata to contain

"subarch": "generic"

2) Merge this branch

This will make ubuntu-cdimage build ubuntu-server daily-preinstalled images for "amd64" and "arm64" correctly, whilst utilising livecd-rootfs ubuntu-cpc project, with subarch set to make it preinstalled image instead of cloud image.

This is compatible with riscv64 and raspi images, as they all specify subarches via metadata override.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, so even though this would indeed make the end images not have 'generic' in the name, I thought Steve wanted not to use SUBARCH at all for these preinstalled images? Since yeah, if it's just about the naming, we can go ahead.

Steve, was it only the naming you were interested in? Or in the way we build the images?

That being said, I *personally* am not a big fan of such implicit transformations, so if it was about me I'd either stick with 'generic' in the name or revamp livecd-rootfs+cdimage to not use SUBARCH for building the preinstalled amd64/arm64 images (which was my original intention when taking the card). The whole livecd-rootfs and ubuntu-cdimage story is already confusing enough, requiring quirk knowledge (like, ubuntu-server preinstalled using ubuntu-cpc as the project etc.). Yet another hidden translation like this feels unnecessary.

I have started working on a branch that would add such images using the 'new way' of preinstalled image building, so with IMAGEFORMAT=ubuntu-image. I'd like us to use ubuntu-image as much as possible as currently right now it's only used for the pi's.

review: Needs Information
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Hi,

On Wed, Jun 16, 2021 at 9:24 AM Łukasz Zemczak
<email address hidden> wrote:
>
> Review: Needs Information
>
> Ok, so even though this would indeed make the end images not have 'generic' in the name, I thought Steve wanted not to use SUBARCH at all for these preinstalled images? Since yeah, if it's just about the naming, we can go ahead.
>

In livecd-rootfs that is not possible. Livecd-rootfs is not using
ubuntu-server project at all, but ubuntu-cpc one. And ubuntu-cpc
without subarch are our cloud image builds which are very different to
what we call ubuntu-server preinstalled.

For example, we install full kernel rather than virtual; we bake in
cloud-init config and allow ubuntu:ubuntu login rather than requiring
datasource.

You will not be able to use subarchless ubuntu-cpc project in
livecd-rootfs to build preinstalled ubuntu-server images.

> Steve, was it only the naming you were interested in? Or in the way we build the images?
>

He naked the name as published by ubuntu-cdimage. I did not see a
request from him to change anything in livecd-rootfs, nor do I see a
way how it could be done. It is a matter of fact that ubuntu-cdimage
projects != livecd-rootfs projects. And we did that intentionally.

> That being said, I *personally* am not a big fan of such implicit transformations, so if it was about me I'd either stick with 'generic' in the name or revamp livecd-rootfs+cdimage to not use SUBARCH for building the preinstalled amd64/arm64 images (which was my original intention when taking the card). The whole livecd-rootfs and ubuntu-cdimage story is already confusing enough, requiring quirk knowledge (like, ubuntu-server preinstalled using ubuntu-cpc as the project etc.). Yet another hidden translation like this feels unnecessary.
>
> I have started working on a branch that would add such images using the 'new way' of preinstalled image building, so with IMAGEFORMAT=ubuntu-image. I'd like us to use ubuntu-image as much as possible as currently right now it's only used for the pi's.

I just want the images published, for which everything was ready
months ago. Are you going to have ubuntu-image based pre-installed
images ready by end of next week?

--
Regards,

Dimitri.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, with the cdimage-to-livefs-map now merged and functional, I'm getting this merged and deployed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'etc/default-arches'
2--- etc/default-arches 2021-04-23 10:48:40 +0000
3+++ etc/default-arches 2021-06-15 18:00:59 +0000
4@@ -60,7 +60,8 @@
5 ubuntu-server daily-preinstalled eoan armhf+raspi3 arm64+raspi3
6 ubuntu-server daily-preinstalled focal armhf+raspi arm64+raspi riscv64
7 ubuntu-server daily-preinstalled groovy armhf+raspi arm64+raspi
8-ubuntu-server daily-preinstalled hirsute- armhf+raspi arm64+raspi riscv64+unleashed riscv64+unmatched
9+ubuntu-server daily-preinstalled hirsute armhf+raspi arm64+raspi riscv64+unleashed riscv64+unmatched
10+ubuntu-server daily-preinstalled impish- armhf+raspi arm64+raspi riscv64+unleashed riscv64+unmatched amd64 arm64
11 ubuntu-server * precise amd64 i386
12 ubuntu-server * trusty amd64 amd64+mac i386 powerpc ppc64el
13 ubuntu-server * xenial amd64 arm64 i386 powerpc ppc64el s390x
14
15=== modified file 'etc/qa-products'
16--- etc/qa-products 2021-03-29 15:54:51 +0000
17+++ etc/qa-products 2021-06-15 18:00:59 +0000
18@@ -82,6 +82,8 @@
19 Ubuntu Server riscv64 ubuntu-server daily-preinstalled preinstalled-server riscv64 iso
20 Ubuntu Server riscv64+unleashed ubuntu-server daily-preinstalled preinstalled-server riscv64+unleashed iso
21 Ubuntu Server riscv64+unmatched ubuntu-server daily-preinstalled preinstalled-server riscv64+unmatched iso
22+Ubuntu Server amd64 ubuntu-server daily-preinstalled preinstalled-server amd64 iso
23+Ubuntu Server arm64 ubuntu-server daily-preinstalled preinstalled-server arm64 iso
24 Ubuntu Server i386 ubuntu-server daily server i386 iso
25 Ubuntu Server powerpc ubuntu-server daily server powerpc iso
26 Ubuntu Server ppc64el ubuntu-server daily server ppc64el iso

Subscribers

People subscribed via source and target branches