Code review comment for lp:~xnox/landscape-client/s390x

Revision history for this message
Alberto Donato (ack) wrote :

Looks good, +1

A few nits inline.

Also, make lint reports a few errors:

landscape/monitor/tests/test_processorinfo.py:370:1: E302 expected 2 blank lines, found 1
landscape/monitor/tests/test_processorinfo.py:379:64: W291 trailing whitespace
landscape/monitor/tests/test_processorinfo.py:380:80: E501 line too long (89 characters)
landscape/monitor/tests/test_processorinfo.py:381:80: E501 line too long (95 characters)
landscape/monitor/tests/test_processorinfo.py:382:80: E501 line too long (90 characters)
landscape/monitor/tests/test_processorinfo.py:383:80: E501 line too long (97 characters)
landscape/monitor/tests/test_processorinfo.py:384:80: E501 line too long (94 characters)
landscape/monitor/tests/test_processorinfo.py:385:80: E501 line too long (95 characters)
landscape/monitor/tests/test_processorinfo.py:393:80: E501 line too long (84 characters)
landscape/monitor/tests/test_processorinfo.py:427:80: E501 line too long (164 characters)
landscape/monitor/tests/test_processorinfo.py:447:80: E501 line too long (164 characters)
landscape/monitor/tests/test_processorinfo.py:474:80: E501 line too long (139 characters)
landscape/monitor/processorinfo.py:278:15: E225 missing whitespace around operator
landscape/monitor/processorinfo.py:291:1: W293 blank line contains whitespace

Some are related to the sample content in the test case. I think you can drop those lines (or just cut out some of the content, since they're not actually considered by the parser.

review: Approve

« Back to merge proposal