Merge lp:~xnox/landscape-client/s390x into lp:~landscape/landscape-client/trunk
Proposed by
Dimitri John Ledkov
Status: | Merged |
---|---|
Merged at revision: | 828 |
Proposed branch: | lp:~xnox/landscape-client/s390x |
Merge into: | lp:~landscape/landscape-client/trunk |
Diff against target: |
113 lines (+92/-1) 2 files modified
landscape/monitor/processorinfo.py (+52/-1) landscape/monitor/tests/test_processorinfo.py (+40/-0) |
To merge this branch: | bzr merge lp:~xnox/landscape-client/s390x |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Collard (community) | Approve | ||
Alberto Donato (community) | Approve | ||
Review via email: mp+284960@code.launchpad.net |
Description of the change
Add support for s390x CPU architecture
To post a comment you must log in.
Looks good, +1
A few nits inline.
Also, make lint reports a few errors:
landscape/ monitor/ tests/test_ processorinfo. py:370: 1: E302 expected 2 blank lines, found 1 monitor/ tests/test_ processorinfo. py:379: 64: W291 trailing whitespace monitor/ tests/test_ processorinfo. py:380: 80: E501 line too long (89 characters) monitor/ tests/test_ processorinfo. py:381: 80: E501 line too long (95 characters) monitor/ tests/test_ processorinfo. py:382: 80: E501 line too long (90 characters) monitor/ tests/test_ processorinfo. py:383: 80: E501 line too long (97 characters) monitor/ tests/test_ processorinfo. py:384: 80: E501 line too long (94 characters) monitor/ tests/test_ processorinfo. py:385: 80: E501 line too long (95 characters) monitor/ tests/test_ processorinfo. py:393: 80: E501 line too long (84 characters) monitor/ tests/test_ processorinfo. py:427: 80: E501 line too long (164 characters) monitor/ tests/test_ processorinfo. py:447: 80: E501 line too long (164 characters) monitor/ tests/test_ processorinfo. py:474: 80: E501 line too long (139 characters) monitor/ processorinfo. py:278: 15: E225 missing whitespace around operator monitor/ processorinfo. py:291: 1: W293 blank line contains whitespace
landscape/
landscape/
landscape/
landscape/
landscape/
landscape/
landscape/
landscape/
landscape/
landscape/
landscape/
landscape/
landscape/
Some are related to the sample content in the test case. I think you can drop those lines (or just cut out some of the content, since they're not actually considered by the parser.