Code review comment for ~xnox/cloud-init:cidr

Revision history for this message
Scott Moser (smoser) wrote :

I really want to clean up the 'network state' object.
It really should store only address and network_prefix and then renderers would render that to either a cidr or address and netmask.

note, i think that <address>/<netmask> is an abomination.
Ie:
 good: 192.168.1.2/24
 good: address=192.168.1.2 netmask: 255.255.255.0
 bad: 192.168.1.2/255.255.255.0

Wherever possible i want to warn or raise error on the bad above.

Rant aside, I'll grab this.

review: Approve

« Back to merge proposal