Merge lp:~xianghui/charm-helpers/support-ipv6 into lp:charm-helpers

[Xiang Hui]

Add a function get_ipv6_addr() to let service charm get an ipv6 address.
And could return a url containing ipv6 address if service charm have set the "use-ipv6" config.

[Juan L. Negron (negronjl)]

LGTM.

+1

review: Approve

[James Page (james-page)]

I backed out this change from lp:charm-helpers - specifically because it breaks the unit tests already present and provides no new ones to exercise this functionality.

I'd also prefer to see this in the contrib.network.ip helper, rather than the clustering hahelper.

[James Page (james-page)]

I'd also like to see the IPv6 support changeset as a complete, tested changeset prior to merging into either charm-helpers or the charms themselves - sorry - but this is a potentially wide impacting topic and we need to ensure that its fully tested prior to landing.

Unmerged revisions

=== modified file 'charmhelpers/contrib/hahelpers/cluster.py'
--- charmhelpers/contrib/hahelpers/cluster.py	2014-06-12 17:55:56 +0000
+++ charmhelpers/contrib/hahelpers/cluster.py	2014-06-27 11:19:30 +0000
@@ -11,6 +11,8 @@
 
 from socket import gethostname as get_unit_hostname
 
+from charmhelpers.fetch import apt_install
+
 from charmhelpers.core.hookenv import (
     log,
     relation_ids,
@@ -179,6 +181,35 @@
         scheme = 'https'
     if is_clustered():
         addr = config_get(vip_setting)
+    elif config_get('use-ipv6'):
+        addr = '[%s]' % get_ipv6_addr()
     else:
         addr = unit_get('private-address')
     return '%s://%s' % (scheme, addr)
+
+
+def get_ipv6_addr(iface="eth0"):
+# TODO Is there a scenario that the ipv6 will be gone in the middle
+# phrase, which caused ipv6 address async.
+
+    try:
+        try:
+            import netifaces
+        except ImportError:
+            apt_install('python-netifaces')
+            import netifaces
+
+        iface_addrs = netifaces.ifaddresses(iface)
+        if netifaces.AF_INET6 not in iface_addrs:
+            raise Exception("Interface '%s' doesn't have an ipv6 address.")
+
+        addresses = netifaces.ifaddresses(iface)[netifaces.AF_INET6]
+        ipv6_addr = [addr['addr']  for addr in addresses \
+                        if 'fe80' not in addr['addr']]
+        if not ipv6_addr:
+            raise Exception("Interface '%s' doesn't have global ipv6 address.") 
+
+        return ipv6_addr[0]
+
+    except ValueError:
+        raise Exception("Invalid interface '%s'" % iface)