Merge lp:~widelands-dev/widelands/string-fixes into lp:widelands

[GunChleoc]

Improved error messages for gl initialize.

The error message for the shading language version is a bit misleading, so I did some rework. Also, the dialog box was too wide for my taste.

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 4107. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/439517974.
Appveyor build 3902. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_string_fixes-3902.

[Notabilis (notabilis27)]

Changes sound good to me and output looks as expected.

review: Approve (diff, testing)

[GunChleoc (gunchleoc)]

Thanks!

@bunnybot merge

=== modified file 'src/graphic/gl/initialize.cc'
--- src/graphic/gl/initialize.cc	2018-10-09 20:18:52 +0000
+++ src/graphic/gl/initialize.cc	2018-10-10 07:05:34 +0000
@@ -185,9 +185,7 @@
 	if (strcmp(shading_language_version_string, "(null)") == 0) {
 		log("ERROR: Unable to detect the shading language version!\n");
 		SDL_ShowSimpleMessageBox(SDL_MESSAGEBOX_ERROR, "OpenGL Error",
-		                         "Widelands won’t work because we were unable to detect the shading "
-		                         "language version -- there is an unknown problem with reading the "
-		                         "information from the graphics driver.",
+		                         "Widelands won't work because we were unable to detect the shading language version.\nThere is an unknown problem with reading the information from the graphics driver.",
 		                         NULL);
 		exit(1);
 	}
@@ -199,8 +197,7 @@
 	if (shading_language_version < 1.20) {
 		log("ERROR: Shading language version is too old!\n");
 		SDL_ShowSimpleMessageBox(SDL_MESSAGEBOX_ERROR, "OpenGL Error",
-		                         "Widelands won’t work because your graphics driver is too old -- "
-		                         "version 1.20 or newer is required.",
+		                         "Widelands won’t work because your graphics driver is too old.\nThe Shading language needs to be version 1.20 or newer.",
 		                         NULL);
 		exit(1);
 	}