Merge lp:~widelands-dev/widelands/fixbug-669380 into lp:widelands

Proposed by Tino
Status: Merged
Approved by: Jens Beyer
Approved revision: no longer in the source branch.
Merged at revision: 5642
Proposed branch: lp:~widelands-dev/widelands/fixbug-669380
Merge into: lp:widelands
Diff against target: 20 lines (+6/-2)
1 file modified
src/CMakeLists.txt (+6/-2)
To merge this branch: bzr merge lp:~widelands-dev/widelands/fixbug-669380
Reviewer Review Type Date Requested Status
Jens Beyer Approve
Review via email: mp+39737@code.launchpad.net

Description of the change

Don't include the win32 icon to the library on all other platforms, but use it for the binary just on win32/mingw.

To post a comment you must log in.
Revision history for this message
Jens Beyer (qcumber-some) wrote :

looks quite good, shouldn't harm on Linux and Mac
shouldn't harm Linux -> Windows MinGW crosscompiling either

Revision history for this message
Jens Beyer (qcumber-some) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/CMakeLists.txt'
--- src/CMakeLists.txt 2010-11-01 05:35:09 +0000
+++ src/CMakeLists.txt 2010-11-01 10:21:23 +0000
@@ -42,10 +42,14 @@
42IF (DEFINED MSVC)42IF (DEFINED MSVC)
43 add_executable (widelands ${GUI_TYPE} main.cc build_info.cc widelands.rc)43 add_executable (widelands ${GUI_TYPE} main.cc build_info.cc widelands.rc)
44else (DEFINED MSVC)44else (DEFINED MSVC)
45 add_executable (widelands ${GUI_TYPE} main.cc build_info.cc)45 if (DEFINED MINGW)
46 add_executable (widelands ${GUI_TYPE} main.cc build_info.cc ${WIN32_ICON_O})
47 else (DEFINED MINGW)
48 add_executable (widelands ${GUI_TYPE} main.cc build_info.cc)
49 endif (DEFINED MINGW)
46endif (DEFINED MSVC)50endif (DEFINED MSVC)
4751
48add_library (widelands_all ${WIN32_ICON_O} ${WL_SRCS_CC} ${WL_SRCS_H})52add_library (widelands_all ${WL_SRCS_CC} ${WL_SRCS_H})
4953
50set (WL_SOURCES_ROOT ${CMAKE_CURRENT_SOURCE_DIR})54set (WL_SOURCES_ROOT ${CMAKE_CURRENT_SOURCE_DIR})
51set (WL_SOURCES_BINARY_ROOT ${CMAKE_CURRENT_BINARY_DIR})55set (WL_SOURCES_BINARY_ROOT ${CMAKE_CURRENT_BINARY_DIR})

Subscribers

People subscribed via source and target branches

to status/vote changes: