Merge lp:~widelands-dev/widelands/bug1132466 into lp:widelands
Status: | Merged |
---|---|
Merged at revision: | 6522 |
Proposed branch: | lp:~widelands-dev/widelands/bug1132466 |
Merge into: | lp:widelands |
Diff against target: |
238 lines (+70/-32) 5 files modified
src/logic/playercommand.cc (+1/-2) src/logic/soldier.cc (+6/-1) src/logic/soldier.h (+3/-1) src/logic/worker.cc (+57/-27) src/logic/worker.h (+3/-1) |
To merge this branch: | bzr merge lp:~widelands-dev/widelands/bug1132466 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
SirVer | Approve | ||
Review via email: mp+150244@code.launchpad.net |
Commit message
Fix bug #1132466 and a potential cheat related to evicting soldiers
The worker leavebuilding task now deals more robustly with situations in which the evicted worker is currently outside of the building.
Furthermore, it is no longer possible to evict soldiers whose current position on the map is not their assigned building (i.e., their location). Note that this was not possible with the standard user interface anyway, but a cheater could have modified her version of the game such that an eviction player command would be sent automatically for her soldiers when they reach low HP during a battle. Such soldiers would have immediately stopped battle and returned home.
lgtm.