Merge lp:~widelands-dev/widelands/bug-1808169-disable-focus into lp:widelands
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 8971 | ||||
Proposed branch: | lp:~widelands-dev/widelands/bug-1808169-disable-focus | ||||
Merge into: | lp:widelands | ||||
Diff against target: |
108 lines (+4/-12) 4 files modified
src/ui_basic/button.cc (+2/-4) src/ui_basic/checkbox.cc (+0/-3) src/ui_basic/panel.cc (+1/-1) src/ui_basic/slider.cc (+1/-4) |
||||
To merge this branch: | bzr merge lp:~widelands-dev/widelands/bug-1808169-disable-focus | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Toni Förster | played | Approve | |
Review via email: mp+361097@code.launchpad.net |
Commit message
Allowing hotkey usage while windows are open.
Description of the change
Allowing to use arrow keys while windows (e.g., ware statistics) are open.
Changed two points:
- The UI::Panel no longer grabs the keyboard focus when it is clicked but shouldn't grab it
- Some components (buttons, slider, checkbox) no longer accept the keyboard focus. I don't know why they ever did so, though. It possibly was connected to the Panel being able to switch between components with the Tab key. But since nearly no component handles any keys, I guess it is no (big) loss. But still my main problem with this merge request is: Does someone knows about or finds a functionality that breaks due to the no longer applied keyboard focus?
Continuous integration builds have changed state:
Travis build 4347. State: failed. Details: https:/ /travis- ci.org/ widelands/ widelands/ builds/ 469721440. /ci.appveyor. com/project/ widelands- dev/widelands/ build/_ widelands_ dev_widelands_ bug_1808169_ disable_ focus-4141.
Appveyor build 4141. State: failed. Details: https:/