Merge lp:~widelands-dev/widelands/bug-1794924-logger-assert into lp:widelands

[GunChleoc]

Use std::cout for logging when calling terminate on shutdown, because the logger might not exist any more.

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 4067. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/434562141.
Appveyor build 3863. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1794924_logger_assert-3863.

[Notabilis (notabilis27)]

Diff is looking okay, but unfortunately I am unable to force the message on purpose so I wasn't able to test it.
As a suggestion: Maybe use std::cerr instead of std::cout for this message?

[GunChleoc (gunchleoc)]

We still have problems with logging std::cerr on Windows, so I prefer keeping it in std::cout for now.

I have tested this by leaving Widelands while another terminal was linking a debug build - that will make my system slow enough to trigger it *lol

Thanks for the review!

@bunnybot merge

=== modified file 'src/wlapplication.cc'
--- src/wlapplication.cc	2018-09-24 08:35:06 +0000
+++ src/wlapplication.cc	2018-09-28 09:31:40 +0000
@@ -103,8 +103,9 @@
  */
 #ifndef _WIN32
 void terminate(int) {
-	log("Waited 5 seconds to close audio. There are some problems here, so killing Widelands."
-	    " Update your sound driver and/or SDL to fix this problem\n");
+	// The logger can already be shut down, so we use cout
+	std::cout << "Waited 5 seconds to close audio. There are some problems here, so killing Widelands."
+	    " Update your sound driver and/or SDL to fix this problem\n";
 	raise(SIGKILL);
 }
 #endif