Merge lp:~widelands-dev/widelands/bug-1540813-island-hopping into lp:widelands

[GunChleoc]

Fixed the hopping in the Island Hopping scenario.

Yep, just some blank spaces.

[Miroslav Remák (miroslavr256)]

Am I missing something? How did adding these two spaces fix the bug? There should be no difference.

[GunChleoc (gunchleoc)]

On my machine, I couldn't get it to hop at all without the blank spaces.

[Miroslav Remák (miroslavr256)]

Was the script running at all (e.g. did you receive the initial welcome message)? Any error messages?

[Miroslav Remák (miroslavr256)]

Also, what made you even attempt such a strange fix? Have you experienced a similar issue before?

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 873. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/117270666.
Appveyor build 706. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1540813_island_hopping-706.

[GunChleoc (gunchleoc)]

The rest of the script was running fine. The fix happened by accident.

[SirVer (sirver)]

I am 99% sure that this cannot change semantics in Lua. Are all other possibilities like flakiness, timing, map locations explored?

> Am 21.03.2016 um 06:02 schrieb GunChleoc <email address hidden>:
>
> The rest of the script was running fine. The fix happened by accident.
> --
> https://code.launchpad.net/~widelands-dev/widelands/bug-1540813-island-hopping/+merge/289579
> You are subscribed to branch lp:widelands.

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 873. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/117270666.
Appveyor build 710. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1540813_island_hopping-710.

[GunChleoc (gunchleoc)]

I can't reproduce the original bug any more, so I'm setting this to invalid/rejected.

review: Disapprove

=== modified file 'data/maps/MP_Scenarios/Island_Hopping.wmf/scripting/first_island.lua'
--- data/maps/MP_Scenarios/Island_Hopping.wmf/scripting/first_island.lua	2016-01-29 16:36:12 +0000
+++ data/maps/MP_Scenarios/Island_Hopping.wmf/scripting/first_island.lua	2016-03-20 14:33:28 +0000
@@ -3,7 +3,7 @@
 -- ==========================
 function _wait_for_castle_on_finish_area(plr, island_idx)
    local finish_area = _finish_areas[island_idx][plr.number]
-   while not check_for_buildings(plr, {atlanteans_castle=1}, finish_area) do
+   while not check_for_buildings(plr, {atlanteans_castle = 1}, finish_area) do
       sleep(1237)
    end
 end