Code review comment for lp:~widelands-dev/widelands/add-xdg-support

Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

Hello Luki, thanks for your support!

I was no ware about that spec. But on OSX such Files should e.g. be found
at ~/Library/Application Support/Wesnoth<Version>/...

OK just found "NOT APPLE". Sound Like I have to do this on a seperate branch,
and it can be tested on *nix only.

Gun: I am not sure if this should make it into R20 it may break some tescases
and documentation. So I would suggets to put this in at the begin of R21,
once R20 is on the road to be relased.

I will try to check how this beaves on OSX perhaps on Sunday.
Not sure If I will be able to unpack that Linux Box in my corner soon.

One nit inline, code looks so far so good.

« Back to merge proposal