Code review comment for lp:~wenchien/checkbox/3d_benchmark

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Thanks for contributing to checkbox.

Note that glxgears is not a benchmark. It doesn't matter if it renders at 3000, 5000 or 15000 fps - the only thing it can do, is show whether 3d acceleration is working.

graphics/glxgears already exists in graphics.txt, not in the benchmark section for the above reason.

You could improve the existing test with the 'get focus' addition though but please forget the FPS_THRESHOLD.

review: Needs Fixing

« Back to merge proposal