Merge lp:~wenchien/checkbox/3d_benchmark into lp:checkbox

[Jesse Sung]

[Rex Tsai (chihchun)]

The glxgears should be always running and be focused, no need to do `wmctrl -a glxgears'. IMHO.
We can also kill the process by Popen.kill, don't need to pull dependence of xmacro as well.

[lp:~wenchien/checkbox/3d_benchmark]

1836. By Jesse Sung on 2012-12-12

Give the focus to glxgears before sleep

[Jesse Sung (wenchien)]

Commit 1836 do the 'wmctrl -a glxgears' before sleep to make sure glxgears get the focus no matter it is already focused or not.

Popen.kill can't be used to terminate glxgears, or the script will not be able to get the output of glxgears...

[Sylvain Pineau (sylvain-pineau)]

Thanks for contributing to checkbox.

Note that glxgears is not a benchmark. It doesn't matter if it renders at 3000, 5000 or 15000 fps - the only thing it can do, is show whether 3d acceleration is working.

graphics/glxgears already exists in graphics.txt, not in the benchmark section for the above reason.

You could improve the existing test with the 'get focus' addition though but please forget the FPS_THRESHOLD.

review: Needs Fixing

[Zygmunt Krynicki (zyga)]

I second Sylvain, glxgears is a crappy benchmark. If that's the point of this patch then we can just kill it right now. Look at LAVA or phoronix for some bechmarks that do make sense.

review: Disapprove

[Daniel Manrique (roadmr)]

Hello,

Apologies, but as previous comments have mentioned, glxgears is not recommended as a benchmark, this is documented in many places, a couple of which are:

https://wiki.archlinux.org/index.php/Benchmarking#glxgears_.28and_why_not_to_use_this_as_a_benchmark.29

http://wiki.cchtml.com/index.php/Glxgears_is_not_a_Benchmark

Checkbox has two existing 3d benchmarks: glmark (with a glmark-es variant) and globs. Both are more thorough than glxgears, however both are really easy for any modern GPU (i.e. even a built-in Intel GPU can blaze through these benchmarks).

Unfortunately the phoronix/unigine combo seems to be the best available benchmark, but it has licensing and installation issues that make it a bit cumbersome to use.

Regardless, since glxgears has little value as a benchmark, I have to reject this proposal, however if you need benchmarking I suggest you use one of the existing tests.

Thanks for your contribution and again, apologies for being unable to accept this in checkbox.

Unmerged revisions

1836. By Jesse Sung on 2012-12-12

Give the focus to glxgears before sleep

1835. By Jesse Sung on 2012-12-06

Add a 3D benchmark test

=== modified file 'data/whitelists/default.whitelist'
--- data/whitelists/default.whitelist	2012-10-23 21:52:31 +0000
+++ data/whitelists/default.whitelist	2012-12-12 09:20:26 +0000
@@ -64,6 +64,7 @@
 graphics/minimum_resolution
 graphics/driver_version
 graphics/VESA_drivers_not_in_use
+graphics/3d_benchmark
 __input__
 input/keyboard
 input/mouse

=== modified file 'jobs/graphics.txt.in'
--- jobs/graphics.txt.in	2012-12-07 17:00:38 +0000
+++ jobs/graphics.txt.in	2012-12-12 09:20:26 +0000
@@ -210,3 +210,14 @@
 depends: graphics/screenshot_fullscreen_video
 command: base64 ${CHECKBOX_DATA}/screenshot_fullscreen_video.jpg
 _description: Attaches the screenshot captured in graphics/screenshot_fullscreen_video.
+
+plugin: shell
+name: graphics/3d_benchmark
+requires:
+ package.name == 'mesa-utils'
+ package.name == 'wmctrl'
+ package.name == 'xmacro'
+ package.name == 'x11-utils'
+command: 3d_benchmark
+_description: make sure glxgears has at least 60 FPS
+

=== added file 'scripts/3d_benchmark'
--- scripts/3d_benchmark	1970-01-01 00:00:00 +0000
+++ scripts/3d_benchmark	2012-12-12 09:20:26 +0000
@@ -0,0 +1,27 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+
+import threading
+import time
+import re
+import sys
+
+from subprocess import Popen, PIPE, check_output, call
+
+FPS_THRESHOLD = 59
+PASSED = 0
+FAILED = -1
+
+proc = Popen('glxgears', stdout = PIPE, stderr = PIPE)
+call('wmctrl -a glxgears', shell = True, stdout = None, stderr = None)
+time.sleep(8)
+call('echo "KeyStrPress Escape" | xmacroplay ":0" > /dev/null 2>&1',
+        shell = True, stdout = None, stderr = None)
+pout, perr = proc.communicate()
+print(pout)
+fps = float(re.search('= (.*) FPS', str(pout)).group(1))
+if fps < FPS_THRESHOLD:
+    sys.exit(FAILED)
+else:
+    sys.exit(PASSED)
+