Merge lp:~wence/fluidity/fix-momcg-les-no-dynamic into lp:fluidity

Proposed by Lawrence Mitchell
Status: Merged
Merged at revision: 4030
Proposed branch: lp:~wence/fluidity/fix-momcg-les-no-dynamic
Merge into: lp:fluidity
Diff against target: 13 lines (+3/-0)
1 file modified
assemble/Momentum_CG.F90 (+3/-0)
To merge this branch: bzr merge lp:~wence/fluidity/fix-momcg-les-no-dynamic
Reviewer Review Type Date Requested Status
Jonathan Bull Approve
Review via email: mp+116674@code.launchpad.net

Description of the change

This should fix tides_in_the_Mediterranean_Sea example on ifort.

To post a comment you must log in.
Revision history for this message
Jonathan Bull (j-bull08) wrote :

Good spot. Why does this break the tides test?

Revision history for this message
Lawrence Mitchell (wence) wrote :

I think the breakage was because previously we were not running the tides test as a longtest with intel fortran. It's possible that gfortran is more lenient about unassociated pointers that are not read.

Revision history for this message
Lawrence Mitchell (wence) wrote :

On 1 Aug 2012, at 11:27, Lawrence Mitchell wrote:

> I think the breakage was because previously we were not running the
> tides test as a longtest with intel fortran. It's possible that
> gfortran is more lenient about unassociated pointers that are not
> read.

Buildbot green http://buildbot-ocean.ese.ic.ac.uk:8080/builders/fix-
momcg-les-no-dynamic/builds/0

Revision history for this message
Jonathan Bull (j-bull08) wrote :

I understand wence's arguments for this and am happy to approve it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'assemble/Momentum_CG.F90'
2--- assemble/Momentum_CG.F90 2012-05-23 14:01:16 +0000
3+++ assemble/Momentum_CG.F90 2012-07-25 15:08:26 +0000
4@@ -439,6 +439,9 @@
5 call leonard_tensor(nu, x, tnu, leonard, alpha, les_option_path)
6
7 ewrite_minmax(leonard)
8+ else
9+ tnu => dummyvector
10+ leonard => dummytensor
11 end if
12 else
13 les_second_order=.false.; les_fourth_order=.false.; wale=.false.; dynamic_les=.false.