Code review comment for ~waveform/ubuntu/+source/livecd-rootfs:cloud-init-boot

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

This looks good for the Pi POV. Sadly, we need to remember that our pi images are not the only consumer of the ubuntu-cpc project - this is something we use for cloud images as well. And those are not using ubuntu-image and the gadget concept. At least that should be our assumption.

I think we'd need to key this on something. We could do that per SUBARCH, and just use the boot partition for the cloud-init seed there, or maybe actually thinking of keying on IMAGEFORMAT. The problem with the second solution is that I'm not completely confident that IMAGEFORMAT=none is only used for our ubuntu-image based classic images (although it feels like it).

Whichever solution we decide on, remember that by default the ARCH, SUBARCH, IMAGEFORMAT etc. config options are not visible by default from hooks. For them to be visible, during auto/config we need to append those to things like the config/chroot file (grep for '>> config/'). Some variables are passed there like that. The cpc fixes hook already includes the /root/config/chroot file so it should all work then.

review: Needs Fixing

« Back to merge proposal