This looks good for the Pi POV. Sadly, we need to remember that our pi images are not the only consumer of the ubuntu-cpc project - this is something we use for cloud images as well. And those are not using ubuntu-image and the gadget concept. At least that should be our assumption.
I think we'd need to key this on something. We could do that per SUBARCH, and just use the boot partition for the cloud-init seed there, or maybe actually thinking of keying on IMAGEFORMAT. The problem with the second solution is that I'm not completely confident that IMAGEFORMAT=none is only used for our ubuntu-image based classic images (although it feels like it).
Whichever solution we decide on, remember that by default the ARCH, SUBARCH, IMAGEFORMAT etc. config options are not visible by default from hooks. For them to be visible, during auto/config we need to append those to things like the config/chroot file (grep for '>> config/'). Some variables are passed there like that. The cpc fixes hook already includes the /root/config/chroot file so it should all work then.
Ok, so Dave gave me a sign that this *is* actually raspi specific. Apparently that part of the hook is only executed whenever linux-image-raspi2 is installed. In light of that info, this feels like it's good to go.
We might need to want to disable raspi2 builds completely soon and maybe try re-branding the raspi3 ones to 'raspi'. Since without this change the old raspi2 preinstalled images will no longer have the ubuntu:ubuntu user.
Configure cloud-init to look for its seed in the vFAT boot partition on
raspberry pi images; the corresponding gadget is configured to place the
user-data, meta-data, and network-config files there.
New changelog entries:
* Drop trying to mount removed maas squashfs.
* Stop overriding initramfs compression default to lzma. LP: #1831736
* Do not force lzma on ubuntu-core builds, the compress format default
should be set universally inside initramfs-tools-ubuntu-core package
instead of getting duplicated multiple times all over the place.
New changelog entries:
* Fix typpo when dropping jasper.
* Drop dead wubi subproject.
* Drop dead jasper subproject.
* Drop old arm platforms.
* Drop ubuntu-desktop-next configs
* Drop ubuntu-desktop-next hooks
* Drop ubuntu-touch configs
* Drop ubuntu-touch hooks
* Drop ubuntu-rtm configs
New changelog entries:
* Add an explicit build-dependency on python3-yaml since livecd-rootfs
uses it, rather than relying on this dependency being pulled in
indirectly via ubuntu-image.
New changelog entries:
* Strip translation files out of the minimal images, another thing that
goes unused when there is no human console user (and we already don't
have the locales themselves present on a minimal image). LP: #1829333.
This looks good for the Pi POV. Sadly, we need to remember that our pi images are not the only consumer of the ubuntu-cpc project - this is something we use for cloud images as well. And those are not using ubuntu-image and the gadget concept. At least that should be our assumption.
I think we'd need to key this on something. We could do that per SUBARCH, and just use the boot partition for the cloud-init seed there, or maybe actually thinking of keying on IMAGEFORMAT. The problem with the second solution is that I'm not completely confident that IMAGEFORMAT=none is only used for our ubuntu-image based classic images (although it feels like it).
Whichever solution we decide on, remember that by default the ARCH, SUBARCH, IMAGEFORMAT etc. config options are not visible by default from hooks. For them to be visible, during auto/config we need to append those to things like the config/chroot file (grep for '>> config/'). Some variables are passed there like that. The cpc fixes hook already includes the /root/config/chroot file so it should all work then.