Code review comment for lp:~wallyworld/juju-core/machiner-access-for-uniter

Revision history for this message
Ian Booth (wallyworld) wrote :

Reviewers: mp+205290_code.launchpad.net,

Message:
Please take a look.

Description:
Allow assigned units read access to machines

This branch allows unit agents to use the machiner
API to get a machine object for their assigned
machine. The server side api looks up the machine
life and the necessary auth function is modified
to allow assigned units as well as the machine
owner.

The implementation is done as a helper function
because a downstream branch also uses it. This
work will be used by the unit agent upgrade worker.

https://code.launchpad.net/~wallyworld/juju-core/machiner-access-for-uniter/+merge/205290

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/60920043/

Affected files (+224, -21 lines):
   A [revision details]
   A state/apiserver/common/auth.go
   M state/apiserver/machine/common_test.go
   M state/apiserver/machine/machiner.go
   M state/apiserver/machine/machiner_test.go

« Back to merge proposal