Merge ~vpa1977/ubuntu/+source/openjdk-lts:lp2003820-native-debug into ubuntu/+source/openjdk-lts:ubuntu/devel

[Vladimir Petko]

This is a final merge proposal of the series [1][2][3]

Summary of changes:
+ * d/rules: use --with-debug-symbols=none (LP: #2003820).

This is required for building chiselled images as embedded debug symbols both bloat JDK image to ~0.5G and are unnecessary.

PPA: ppa:vpa1977/openjdk-new-repack [4]

Testing:

sudo apt install openjdk-11-jdk openjdk-11-dbg
echo "public class infinite { public static void main(String[] args) { while (true){} } }" > infinite.java
/usr/lib/jvm/java-11-openjdk-amd64/bin/javac infinite.java
/usr/lib/jvm/java-11-openjdk-amd64/bin/java -cp . infinite&
[1] 41978
sudo /usr/lib/jvm/java-11-openjdk-amd64/bin/jhsdb jmap --heap --pid 41978
--------------cut------------------------------
Attaching to process ID 41978, please wait...
Debugger attached successfully.
Server compiler detected.
JVM version is 11.0.19+5-post-Ubuntu-0ubuntu1ppa2

using thread-local object allocation.
Garbage-First (G1) GC with 2 thread(s)

Heap Configuration:
   MinHeapFreeRatio = 40
   MaxHeapFreeRatio = 70
   MaxHeapSize = 1029701632 (982.0MB)
   NewSize = 1363144 (1.2999954223632812MB)
   MaxNewSize = 617611264 (589.0MB)
   OldSize = 5452592 (5.1999969482421875MB)
   NewRatio = 2
   SurvivorRatio = 8
   MetaspaceSize = 21807104 (20.796875MB)
   CompressedClassSpaceSize = 1073741824 (1024.0MB)
   MaxMetaspaceSize = 17592186044415 MB
   G1HeapRegionSize = 1048576 (1.0MB)

Heap Usage:
G1 Heap:
   regions = 982
   capacity = 1029701632 (982.0MB)
   used = 733184 (0.69921875MB)
   free = 1028968448 (981.30078125MB)
   0.07120353869653767% used
G1 Young Generation:
Eden Space:
   regions = 0
   capacity = 8388608 (8.0MB)
   used = 0 (0.0MB)
   free = 8388608 (8.0MB)
   0.0% used
Survivor Space:
   regions = 0
   capacity = 0 (0.0MB)
   used = 0 (0.0MB)
   free = 0 (0.0MB)
   0.0% used
G1 Old Generation:
   regions = 2
   capacity = 56623104 (54.0MB)
   used = 0 (0.0MB)
   free = 56623104 (54.0MB)
   0.0% used

------cut--------------------

[1] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-lts/+git/openjdk-lts/+merge/439014
[2] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-lts/+git/openjdk-lts/+merge/439016
[3] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-lts/+git/openjdk-lts/+merge/439029
[4] https://launchpad.net/~vpa1977/+archive/ubuntu/openjdk-new-repack

[Vladimir Petko (vpa1977)]

Note, we already have an issue with NMT dumps (will raise a bug after investigation) - callsites are not resolved. This is not a regression:
Using 11.0.18+10-0ubuntu3:

/usr/lib/jvm/java-11-openjdk-amd64/bin/java -XX:NativeMemoryTracking=detail -cp . infinite&
[1] 4739
/usr/lib/jvm/java-11-openjdk-amd64/bin/jcmd 4739 VM.native_memory detail
----------------------------------------------------------cut------------------------------
4739:

Native Memory Tracking:

Total: reserved=2415496KB, committed=131892KB
- Java Heap (reserved=1005568KB, committed=65536KB)
                            (mmap: reserved=1005568KB, committed=65536KB)

- Class (reserved=1056874KB, committed=4970KB)
                            (classes #478)
                            ( instance classes #413, array classes #65)
                            (malloc=106KB #517)
                            (mmap: reserved=1056768KB, committed=4864KB)
                            ( Metadata: )
                            ( reserved=8192KB, committed=4352KB)
                            ( used=146KB)
                            ( free=4206KB)
                            ( waste=0KB =0.00%)
                            ( Class space:)
                            ( reserved=1048576KB, committed=512KB)
                            ( used=5KB)
                            ( free=507KB)
                            ( waste=0KB =0.00%)

- Thread (reserved=17486KB, committed=842KB)
                            (thread #17)
                            (stack: reserved=17408KB, committed=764KB)
                            (malloc=60KB #104)
                            (arena=18KB #32)

- Code (reserved=247724KB, committed=7584KB)
                            (malloc=36KB #394)
                            (mmap: reserved=247688KB, committed=7548KB)

- GC (reserved=74681KB, committed=39797KB)
                            (malloc=4465KB #704)
                            (mmap: reserved=70216KB, committed=35332KB)

- Compiler (reserved=136KB, committed=136KB)
                            (malloc=4KB #51)
                            (arena=133KB #5)

- Internal (reserved=556KB, committed=556KB)
                            (malloc=524KB #931)
                            (mmap: reserved=32KB, committed=32KB)

- Symbol (reserved=1038KB, committed=1038KB)
                            (malloc=678KB #16)
                            (arena=360KB #1)

- Native Memory Tracking (reserved=276KB, committed=276KB)
                            (malloc=166KB #2361)
                            (tracking overhead=110KB)

- Shared class space (reserved=10872KB, committed=10872KB)
                            (mmap: reserved=10872KB, committed=10872KB)

- Arena Chunk (reserved=173KB, committed=173KB)
                            (malloc=173KB)

- Logging (reserved=4KB, committed=4KB)
                            (malloc=4KB #192)

- Arguments (reserved=18KB, committed=18...

[Vladimir Petko (vpa1977)]

This is caused by us fully stripping symbol tables.

[Dan Bungert (dbungert)]

review: Approve

diff --git a/debian/changelog b/debian/changelog
index dca0e12..8d9ada6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,4 @@
-openjdk-lts (11.0.18+10-0ubuntu4) UNRELEASED; urgency=medium
+openjdk-lts (11.0.18+10-0ubuntu4) lunar; urgency=medium
 
   * d/p: drop obsolete patches (LP: #2011653).
     - workaround_expand_exec_shield_cs_limit.diff: obsoleted by
@@ -6,6 +6,7 @@ openjdk-lts (11.0.18+10-0ubuntu4) UNRELEASED; urgency=medium
     - generated-headers.patch: include is already added by openjdk makefile.
     - parallel-build-fix.diff: include is not necessary.
   * d/copyright, d/watch: implement uscan repackaging (LP: #2011749).
+  * d/rules: use --with-debug-symbols=none (LP: #2003820).
 
  -- Vladimir Petko <[e-mail]>  Thu, 16 Mar 2023 08:39:50 +1300
 
diff --git a/debian/rules b/debian/rules
index f32fa38..e3befce 100755
--- a/debian/rules
+++ b/debian/rules
@@ -494,7 +494,7 @@ COMMON_CONFIGURE_ARGS += \
 
 COMMON_CONFIGURE_ARGS += \
 	--with-debug-level=release \
-	--with-native-debug-symbols=internal \
+	--with-native-debug-symbols=none \
 	--enable-unlimited-crypto \
 	--with-zlib=system \
 	--with-giflib=system \