Merge ~vpa1977/ubuntu/+source/openjdk-lts:lp2011653-drop-patches into ubuntu/+source/openjdk-lts:ubuntu/devel

Proposed by Vladimir Petko
Status: Merged
Merged at revision: 777281e86124b4f18858e0580bef852bc6522ad1
Proposed branch: ~vpa1977/ubuntu/+source/openjdk-lts:lp2011653-drop-patches
Merge into: ubuntu/+source/openjdk-lts:ubuntu/devel
Diff against target: 113 lines (+11/-15)
4 files modified
debian/changelog (+10/-0)
debian/patches/hotspot-disable-exec-shield-workaround.diff (+1/-1)
debian/patches/series (+0/-3)
dev/null (+0/-11)
Reviewer Review Type Date Requested Status
Dan Bungert (community) Approve
Steve Langasek Pending
git-ubuntu import Pending
Review via email: mp+439014@code.launchpad.net

Description of the change

Please do not merge, this merge proposal is a part of a series [1][2][3].

Summary of changes:
  * d/p: drop obsolete patches (LP: #2011653).
    - workaround_expand_exec_shield_cs_limit.diff: obsoleted by
      hotspot-disable-exec-shield-workaround.diff.
    - generated-headers.patch: include is already added by openjdk makefile.
    - parallel-build-fix.diff: include is not necessary.

PPA: ppa:vpa1977/openjdk-new-repack [4]

Testing:
 No functional changes in this MP:
       - workaround_expand_exec_shield_cs_limit.diff is obsoleted by another patch applied later in the series
       - generated-headers.patch/parallel-build-fix.patch provide an include directory. If something relies on files in those directories, compilation will be broken.
       - parallel-build-fix.diff: provides a duplicate include path.

  Compilation must succeed [5]

[1] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-lts/+git/openjdk-lts/+merge/439014
[2] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-lts/+git/openjdk-lts/+merge/439016
[3] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-lts/+git/openjdk-lts/+merge/439029
[4] https://launchpad.net/~vpa1977/+archive/ubuntu/openjdk-new-repack
[5] https://launchpad.net/~vpa1977/+archive/ubuntu/openjdk-new-repack/+sourcepub/14560391/+listing-archive-extra

To post a comment you must log in.
Revision history for this message
Dan Bungert (dbungert) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 4ced2ad..b4cabb7 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,13 @@
6+openjdk-lts (11.0.18+10-0ubuntu4) UNRELEASED; urgency=medium
7+
8+ * d/p: drop obsolete patches (LP: #2011653).
9+ - workaround_expand_exec_shield_cs_limit.diff: obsoleted by
10+ hotspot-disable-exec-shield-workaround.diff.
11+ - generated-headers.patch: include is already added by openjdk makefile.
12+ - parallel-build-fix.diff: include is not necessary.
13+
14+ -- Vladimir Petko <vladimir.petko@canonical.com> Thu, 16 Mar 2023 08:39:50 +1300
15+
16 openjdk-lts (11.0.18+10-0ubuntu3) lunar; urgency=medium
17
18 * debian/JB-jre-headless.postinst.in: trigger ca-certificates-java after jre
19diff --git a/debian/patches/generated-headers.patch b/debian/patches/generated-headers.patch
20deleted file mode 100644
21index f9aa947..0000000
22--- a/debian/patches/generated-headers.patch
23+++ /dev/null
24@@ -1,20 +0,0 @@
25---- a/make/lib/Awt2dLibraries.gmk
26-+++ b/make/lib/Awt2dLibraries.gmk
27-@@ -383,7 +383,7 @@
28- INCLUDE_FILES := $(BUILD_LIBLCMS_INCLUDE_FILES), \
29- OPTIMIZATION := HIGHEST, \
30- CFLAGS := $(LCMS_CFLAGS_JDKLIB) \
31-- $(LCMS_CFLAGS), \
32-+ $(LCMS_CFLAGS) -I$(SUPPORT_OUTPUTDIR)/headers/java.desktop, \
33- CFLAGS_solaris := -xc99=no_lib, \
34- CFLAGS_windows := -DCMS_IS_WINDOWS_, \
35- EXTRA_HEADER_DIRS := \
36-@@ -432,7 +432,7 @@
37- NAME := javajpeg, \
38- INCLUDE_FILES := $(BUILD_LIBJAVAJPEG_INCLUDE_FILES), \
39- OPTIMIZATION := HIGHEST, \
40-- CFLAGS := $(CFLAGS_JDKLIB), \
41-+ CFLAGS := $(CFLAGS_JDKLIB) -I$(SUPPORT_OUTPUTDIR)/headers/java.desktop, \
42- HEADERS_FROM_SRC := $(LIBJPEG_HEADERS_FROM_SRC), \
43- DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough shift-negative-value array-bounds, \
44- LDFLAGS := $(LDFLAGS_JDKLIB) \
45diff --git a/debian/patches/hotspot-disable-exec-shield-workaround.diff b/debian/patches/hotspot-disable-exec-shield-workaround.diff
46index 34c6e14..d8c1235 100644
47--- a/debian/patches/hotspot-disable-exec-shield-workaround.diff
48+++ b/debian/patches/hotspot-disable-exec-shield-workaround.diff
49@@ -4,7 +4,7 @@
50 * updates (JDK-8023956).
51 */
52 void os::workaround_expand_exec_shield_cs_limit() {
53--#if defined(IA32) && !defined(ZERO)
54+-#if defined(IA32)
55 +#if 0
56 assert(Linux::initial_thread_stack_bottom() != NULL, "sanity");
57 size_t page_size = os::vm_page_size();
58diff --git a/debian/patches/parallel-build-fix.diff b/debian/patches/parallel-build-fix.diff
59deleted file mode 100644
60index c414eb2..0000000
61--- a/debian/patches/parallel-build-fix.diff
62+++ /dev/null
63@@ -1,12 +0,0 @@
64-Index: b/make/hotspot/gensrc/GensrcJfr.gmk
65-===================================================================
66---- a/make/hotspot/gensrc/GensrcJfr.gmk
67-+++ b/make/hotspot/gensrc/GensrcJfr.gmk
68-@@ -41,6 +41,7 @@ $(eval $(call SetupJavaCompilation, BUIL
69- SETUP := GENERATE_JFRBYTECODE, \
70- SRC := $(JFR_TOOLS_SRCDIR), \
71- BIN := $(JFR_TOOLS_OUTPUTDIR), \
72-+ INCLUDES := build/tools/jfr, \
73- ))
74-
75- TARGETS += $(BUILD_JFR_TOOLS)
76diff --git a/debian/patches/series b/debian/patches/series
77index 27795ee..b82a5bd 100644
78--- a/debian/patches/series
79+++ b/debian/patches/series
80@@ -5,7 +5,6 @@ icedtea-override-redirect-compiz.diff
81 libpcsclite-dlopen.diff
82 jexec.diff
83 default-jvm-cfg.diff
84-workaround_expand_exec_shield_cs_limit.diff
85 adlc-parser.diff
86 multiple-pkcs11-library-init.diff
87 s390x-thread-stack-size.diff
88@@ -21,8 +20,6 @@ hotspot-disable-exec-shield-workaround.diff
89 atk-wrapper-security.diff
90 dnd-files.diff
91 hotspot-libpath.diff
92-generated-headers.patch
93-parallel-build-fix.diff
94 #m68k-support.diff
95 reproducible-properties-timestamp.diff
96 reproducible-javadoc-timestamp.diff
97diff --git a/debian/patches/workaround_expand_exec_shield_cs_limit.diff b/debian/patches/workaround_expand_exec_shield_cs_limit.diff
98deleted file mode 100644
99index fc635ec..0000000
100--- a/debian/patches/workaround_expand_exec_shield_cs_limit.diff
101+++ /dev/null
102@@ -1,11 +0,0 @@
103---- a/src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp
104-+++ b/src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp
105-@@ -874,7 +874,7 @@
106- * updates (JDK-8023956).
107- */
108- void os::workaround_expand_exec_shield_cs_limit() {
109--#if defined(IA32)
110-+#if defined(IA32) && !defined(ZERO)
111- assert(Linux::initial_thread_stack_bottom() != NULL, "sanity");
112- size_t page_size = os::vm_page_size();
113-

Subscribers

People subscribed via source and target branches