Ubuntu
python-pam package

Code review comment for lp:~vorlon/ubuntu/quantal/python-pam/python3

  1. Quantal (12.10)
  2. python3
  3. Merge into quantal
Revision history for this message
Barry Warsaw (barry) wrote :

Steve, this looks good. My only minor thought is the API change in the repr() to always be unicode. I.e. this is a change for the Python 2 version, but since it's just a repr it doesn't bother me. I like Saphhira's additional patch, though with a few changes.

I'll mark this approved, merge yours and Sapphira's into trunk and upload.

Thanks both of you for the patch!

Reply

« Back to merge proposal